Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7981019: views: Get rid of TabbedPane::CreateWrapper(). (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

views: Get rid of TabbedPane::CreateWrapper(). This is called only once, better to inline it in the call site, less code. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102111

Patch Set 1 #

Patch Set 2 : add lifetime comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M views/controls/tabbed_pane/tabbed_pane.h View 1 chunk +0 lines, -3 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 3 months ago (2011-09-21 02:18:51 UTC) #1
sky
9 years, 3 months ago (2011-09-21 14:51:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698