Add Mouse hover behavior to Mac Panels when minimized

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/find_bar/find_bar.h"
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
@@ skipping 286 matching lines @@
       expected_panel_menu_items[4].enabled = true;
     }
     ValidateSettingsMenuItems(settings_menu_model.get(),
                               arraysize(expected_panel_menu_items),
                               expected_panel_menu_items);
 
     panel->Close();
   }
 
   void TestMinimizeRestore() {
+    // This constant is used to generate a point 'sufficiently higher then
+    // top edge of the panel'. On some platforms (Mac) we extend hover area
+    // a bit above the minimized panel as well, so it takes significant
+    // distance to 'move mouse out' of the hover-sensitive area.
+    const int kFarEnoughFromHoverArea = 153;
+
     std::vector<Panel*> panels = PanelManager::GetInstance()->panels();
     std::vector<gfx::Rect> test_begin_bounds = GetAllPanelsBounds();
     std::vector<gfx::Rect> expected_bounds = test_begin_bounds;
     std::vector<Panel::ExpansionState> expected_expansion_states(
         panels.size(), Panel::EXPANDED);
     std::vector<NativePanelTesting*> native_panels_testing(panels.size());
     for (size_t i = 0; i < panels.size(); ++i) {
       native_panels_testing[i] =
           NativePanelTesting::Create(panels[i]->native_panel());
     }
@@ skipping 41 matching lines @@
     for (size_t index = 0; index < panels.size(); ++index) {
       // Hover mouse on minimized panel.
       // Verify titlebar is exposed on all panels.
       gfx::Point hover_point(panels[index]->GetRestoredBounds().origin());
       native_panels_testing[index]->SetMousePositionForMinimizeRestore(
           hover_point);
       CheckPanelBounds(panels, titlebar_exposed_bounds);
       CheckExpansionStates(titlebar_exposed_states);
 
       // Hover mouse above the panel. Verify all panels are minimized.
-      hover_point.set_y(panels[index]->GetRestoredBounds().y() - 10);
+      hover_point.set_y(
+          panels[index]->GetRestoredBounds().y() - kFarEnoughFromHoverArea);
       native_panels_testing[index]->SetMousePositionForMinimizeRestore(
           hover_point);
       CheckPanelBounds(panels, minimized_bounds);
       CheckExpansionStates(minimized_states);
 
       // Hover mouse below minimized panel.
       // Verify titlebar is exposed on all panels.
       hover_point.set_y(panels[index]->GetRestoredBounds().y() +
                         panels[index]->GetRestoredBounds().height() + 5);
       native_panels_testing[index]->SetMousePositionForMinimizeRestore(
           hover_point);
       CheckPanelBounds(panels, titlebar_exposed_bounds);
       CheckExpansionStates(titlebar_exposed_states);
 
       // Hover below titlebar exposed panel.  Verify nothing changed.
       hover_point.set_y(panels[index]->GetRestoredBounds().y() +
                         panels[index]->GetRestoredBounds().height() + 6);
       native_panels_testing[index]->SetMousePositionForMinimizeRestore(
           hover_point);
       CheckPanelBounds(panels, titlebar_exposed_bounds);
       CheckExpansionStates(titlebar_exposed_states);
 
       // Hover mouse above panel.  Verify all panels are minimized.
-      hover_point.set_y(panels[index]->GetRestoredBounds().y() - 10);
+      hover_point.set_y(
+          panels[index]->GetRestoredBounds().y() - kFarEnoughFromHoverArea);
       native_panels_testing[index]->SetMousePositionForMinimizeRestore(
           hover_point);
       CheckPanelBounds(panels, minimized_bounds);
       CheckExpansionStates(minimized_states);
     }
 
     // Test restore.  All panels are currently in minimized state.
     for (size_t index = 0; index < panels.size(); ++index) {
       // Hover on the last panel.  This is to test the case of clicking on the
       // panel when it's in titlebar exposed state.
@@ skipping 404 matching lines @@
     MessageLoop::current()->PostTask(FROM_HERE, new MessageLoop::QuitTask());
     MessageLoop::current()->RunAllPending();
   }
   EXPECT_LT(bounds_on_shrink.width(), bounds_on_grow.width());
   EXPECT_GT(bounds_on_shrink.width(), initial_bounds.width());
   EXPECT_EQ(bounds_on_shrink.height(), initial_bounds.height());
 
   panel->Close();
 }
 
-#if defined(TOOLKIT_GTK)
+#if defined(TOOLKIT_GTK) || defined(OS_MACOSX)
 #define MAYBE_MinimizeRestore MinimizeRestore
 #else
 #define MAYBE_MinimizeRestore DISABLED_MinimizeRestore
 #endif
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, MAYBE_MinimizeRestore) {
   // Disable mouse watcher.  We'll simulate mouse movements for test.
   NativePanelTesting::GetPanelMouseWatcherInstance()->EnableTestingMode();
 
   // Test with one panel.
@@ skipping 168 matching lines @@
   EXPECT_EQ(1, tabbed_browser->tab_count());
   ASSERT_TRUE(tabbed_browser->window()->IsDownloadShelfVisible());
   tabbed_browser->CloseWindow();
 #endif
 
   EXPECT_EQ(1, panel_browser->tab_count());
   ASSERT_FALSE(panel_browser->window()->IsDownloadShelfVisible());
 
   panel_browser->CloseWindow();
 }