Add Mouse hover behavior to Mac Panels when minimized

chrome/browser/ui/panels/panel_browser_window_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
 
 #include "base/logging.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
+#include "chrome/browser/ui/panels/panel_mouse_watcher.h"
 #import "chrome/browser/ui/panels/panel_titlebar_view_cocoa.h"
 #import "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 #include "content/common/native_web_keyboard_event.h"
 
 namespace {
 
 // Use this instead of 0 for minimum size of a window when doing opening and
 // closing animations, since OSX window manager does not like 0-sized windows
 // (according to avi@).
 const int kMinimumWindowSize = 1;
@@ skipping 28 matching lines @@
   : browser_(browser),
     panel_(panel),
     bounds_(bounds),
     restored_height_(bounds.height()),
     is_shown_(false),
     has_find_bar_(false) {
   controller_ = [[PanelWindowControllerCocoa alloc] initWithBrowserWindow:this];
 }
 
 PanelBrowserWindowCocoa::~PanelBrowserWindowCocoa() {
+  PanelMouseWatcher* watcher = PanelMouseWatcher::GetInstance();
+  if (watcher->IsSubscribed(this))
+    watcher->RemoveSubscriber(this);
 }
 
 bool PanelBrowserWindowCocoa::isClosed() {
   return !controller_;
 }
 
 void PanelBrowserWindowCocoa::ShowPanel() {
   if (isClosed())
     return;
 
@@ skipping 31 matching lines @@
   // Store the expanded height for subsequent minimize/restore operations.
   if (panel_->expansion_state() == Panel::EXPANDED)
     restored_height_ = NSHeight(frame);
 }
 
 void PanelBrowserWindowCocoa::OnPanelExpansionStateChanged(
     Panel::ExpansionState expansion_state) {
   int height;  // New height of the Panel in screen coordinates.
   switch (expansion_state) {
     case Panel::EXPANDED:
+      PanelMouseWatcher::GetInstance()->RemoveSubscriber(this);
       height = restored_height_;
       break;
     case Panel::TITLE_ONLY:
       height = [controller_ titlebarHeightInScreeenCoordinates];
       break;
     case Panel::MINIMIZED:
-      height = 3;  // TODO(dimich) merge with GTK patch which defines it better.
+      PanelMouseWatcher::GetInstance()->AddSubscriber(this);
+      height = PanelManager::minimized_panel_height();
       break;
     default:
       NOTREACHED();
       height = restored_height_;
       break;
   }
 
   int bottom = panel_->manager()->GetBottomPositionForExpansionState(
       expansion_state);
   // This math is in platform-independent screen coordinates (inverted),
   // because it's what SetPanelBounds expects.
   gfx::Rect bounds = bounds_;
   bounds.set_y(bottom - height);
   bounds.set_height(height);
   SetPanelBounds(bounds);
 }
 
+// Coordinates are in gfx coordinate system (screen, with 0,0 at the top left).
 bool PanelBrowserWindowCocoa::ShouldBringUpPanelTitlebar(int mouse_x,
                                                          int mouse_y) const {
-  NOTIMPLEMENTED();
-  return false;
+  return bounds_.x() <= mouse_x && mouse_x <= bounds_.right() &&
+      mouse_y >= bounds_.y();
 }
 
 void PanelBrowserWindowCocoa::ClosePanel() {
   if (isClosed())
       return;
 
   NSWindow* window = [controller_ window];
   [window performClose:controller_];
 }
 
@@ skipping 143 matching lines @@
   PanelBrowserWindowCocoa* native_panel_window_;
 };
 
 // static
 NativePanelTesting* NativePanelTesting::Create(NativePanel* native_panel) {
   return new NativePanelTestingCocoa(native_panel);
 }
 
 // static
 PanelMouseWatcher* NativePanelTesting::GetPanelMouseWatcherInstance() {
-  return NULL;
+  return PanelMouseWatcher::GetInstance();
 }
 
 NativePanelTestingCocoa::NativePanelTestingCocoa(NativePanel* native_panel)
   : native_panel_window_(static_cast<PanelBrowserWindowCocoa*>(native_panel)) {
 }
 
 PanelTitlebarViewCocoa* NativePanelTestingCocoa::titlebar() {
   return [native_panel_window_->controller_ titlebarView];
 }
 
@@ skipping 11 matching lines @@
 }
 
 void NativePanelTestingCocoa::CancelDragTitlebar() {
   [titlebar() cancelDragTitlebar];
 }
 
 void NativePanelTestingCocoa::FinishDragTitlebar() {
   [titlebar() finishDragTitlebar];
 }
 
+// TODO(dimich) this method is platform-independent. Reuse it.
 void NativePanelTestingCocoa::SetMousePositionForMinimizeRestore(
     const gfx::Point& hover_point) {
-  NOTIMPLEMENTED();
+  PanelMouseWatcher::GetInstance()->HandleMouseMovement(hover_point);
+  MessageLoopForUI::current()->RunAllPending();
 }
 
 int NativePanelTestingCocoa::TitleOnlyHeight() const {
-  NOTIMPLEMENTED();
-  return -1;
+  return [native_panel_window_->controller_ titlebarHeightInScreeenCoordinates];
 }