Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/sync/engine/syncer_unittest.cc

Issue 7981006: [Sync] use base::Time in sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix win compile error Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/syncer_unittest.cc
diff --git a/chrome/browser/sync/engine/syncer_unittest.cc b/chrome/browser/sync/engine/syncer_unittest.cc
index d4242ed967093a66ff95242d5ba1af7c29a46572..91f2d2d2f2e0d4a05c79dd1dba0f77b0047fed36 100644
--- a/chrome/browser/sync/engine/syncer_unittest.cc
+++ b/chrome/browser/sync/engine/syncer_unittest.cc
@@ -17,6 +17,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/stringprintf.h"
#include "base/string_number_conversions.h"
+#include "base/time.h"
#include "base/tracked.h"
#include "build/build_config.h"
#include "chrome/browser/sync/engine/conflict_resolver.h"
@@ -39,6 +40,7 @@
#include "chrome/browser/sync/test/engine/test_directory_setter_upper.h"
#include "chrome/browser/sync/test/engine/test_id_factory.h"
#include "chrome/browser/sync/test/engine/test_syncable_utils.h"
+#include "chrome/browser/sync/util/time.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::TimeDelta;
@@ -314,9 +316,10 @@ class SyncerTest : public testing::Test,
entry.Put(syncable::SPECIFICS, DefaultBookmarkSpecifics());
// Set the time to 30 seconds in the future to reduce the chance of
// flaky tests.
- int64 now_server_time = ClientTimeToServerTime(syncable::Now());
- int64 now_plus_30s = ServerTimeToClientTime(now_server_time + 30000);
- int64 now_minus_2h = ServerTimeToClientTime(now_server_time - 7200000);
+ const base::Time& now_plus_30s =
+ base::Time::Now() + base::TimeDelta::FromSeconds(30);
+ const base::Time& now_minus_2h =
+ base::Time::Now() - base::TimeDelta::FromHours(2);
entry.Put(syncable::MTIME, now_plus_30s);
for (size_t i = 0 ; i < arraysize(test->features) ; ++i) {
switch (test->features[i]) {
@@ -894,9 +897,8 @@ TEST_F(SyncerTest, TestCommitListOrderingDeleteMovedItems) {
TEST_F(SyncerTest, TestCommitListOrderingWithNesting) {
ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
ASSERT_TRUE(dir.good());
- int64 now_server_time = ClientTimeToServerTime(syncable::Now());
- int64 now_minus_2h = ServerTimeToClientTime(now_server_time - 7200000);
-
+ const base::Time& now_minus_2h =
+ base::Time::Now() - base::TimeDelta::FromHours(2);
{
WriteTransaction wtrans(FROM_HERE, UNITTEST, dir);
{
@@ -1970,7 +1972,7 @@ TEST_F(SyncerTest, DoublyChangedWithResolver) {
TEST_F(SyncerTest, CommitsUpdateDoesntAlterEntry) {
ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
CHECK(dir.good());
- int64 test_time = 123456;
+ const base::Time& test_time = ProtoTimeToTime(123456);
int64 entry_metahandle;
{
WriteTransaction wtrans(FROM_HERE, UNITTEST, dir);

Powered by Google App Engine
This is Rietveld 408576698