Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2601)

Unified Diff: base/debug/trace_event.h

Issue 7981004: add classes trace_analyzer::Query and TraceAnalyzer to make it easy to search through trace data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/trace_event.h
diff --git a/base/debug/trace_event.h b/base/debug/trace_event.h
index d5aa256dc15cb769c2de0a312eb5c2084f7f56ba..4048f73fd2d10114c613b87243c6787123e133ba 100644
--- a/base/debug/trace_event.h
+++ b/base/debug/trace_event.h
@@ -419,6 +419,10 @@ class BASE_EXPORT TraceValue {
return value;
}
+ bool is_string() const {
+ return type_ == TRACE_TYPE_STRING || type_ == TRACE_TYPE_STATIC_STRING;
+ }
+
void AppendAsJSON(std::string* out) const;
Type type() const {
@@ -445,7 +449,7 @@ class BASE_EXPORT TraceValue {
return value_.as_pointer;
}
const char* as_string() const {
- DCHECK(type_ == TRACE_TYPE_STRING || type_ == TRACE_TYPE_STATIC_STRING);
+ DCHECK(is_string());
return value_.as_string;
}
const char** as_assignable_string() {
@@ -485,6 +489,9 @@ class TraceEvent {
bool copy);
~TraceEvent();
+ static const char* GetPhaseStr(TraceEventPhase phase);
+ static TraceEventPhase GetPhase(const char* phase);
+
// Serialize event data to JSON
static void AppendEventsAsJSON(const std::vector<TraceEvent>& events,
size_t start,
« no previous file with comments | « base/base.gyp ('k') | base/debug/trace_event.cc » ('j') | base/test/trace_event_analyzer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698