Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: base/debug/trace_event.cc

Issue 7981004: add classes trace_analyzer::Query and TraceAnalyzer to make it easy to search through trace data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/trace_event.cc
diff --git a/base/debug/trace_event.cc b/base/debug/trace_event.cc
index 347644f982ef3a4f3cd260b55a8b452e5217db3e..9e44096935116d45d3339d50f67adcaff48a560a 100644
--- a/base/debug/trace_event.cc
+++ b/base/debug/trace_event.cc
@@ -118,22 +118,6 @@ void TraceValue::AppendAsJSON(std::string* out) const {
namespace {
-const char* GetPhaseStr(TraceEventPhase phase) {
- switch(phase) {
- case TRACE_EVENT_PHASE_BEGIN:
- return "B";
- case TRACE_EVENT_PHASE_INSTANT:
- return "I";
- case TRACE_EVENT_PHASE_END:
- return "E";
- case TRACE_EVENT_PHASE_METADATA:
- return "M";
- default:
- NOTREACHED() << "Invalid phase argument";
- return "?";
- }
-}
-
size_t GetAllocLength(const char* str) { return str ? strlen(str) + 1 : 0; }
// Copies |*member| into |*buffer|, sets |*member| to point to this new
@@ -220,6 +204,38 @@ TraceEvent::TraceEvent(unsigned long process_id,
TraceEvent::~TraceEvent() {
}
+const char* TraceEvent::GetPhaseStr(TraceEventPhase phase) {
+ switch(phase) {
+ case TRACE_EVENT_PHASE_BEGIN:
+ return "B";
+ case TRACE_EVENT_PHASE_INSTANT:
+ return "I";
+ case TRACE_EVENT_PHASE_END:
+ return "E";
+ case TRACE_EVENT_PHASE_METADATA:
+ return "M";
+ default:
+ NOTREACHED() << "Invalid phase argument";
+ return "?";
+ }
+}
+
+TraceEventPhase TraceEvent::GetPhase(const char* phase) {
+ switch(*phase) {
+ case 'B':
+ return TRACE_EVENT_PHASE_BEGIN;
+ case 'I':
+ return TRACE_EVENT_PHASE_INSTANT;
+ case 'E':
+ return TRACE_EVENT_PHASE_END;
+ case 'M':
+ return TRACE_EVENT_PHASE_METADATA;
+ default:
+ NOTREACHED() << "Invalid phase name";
+ return TRACE_EVENT_PHASE_METADATA;
+ }
+}
+
void TraceEvent::AppendEventsAsJSON(const std::vector<TraceEvent>& events,
size_t start,
size_t count,

Powered by Google App Engine
This is Rietveld 408576698