[ntp4] Handle max tile limit properly when adding bookmarks.

chrome/browser/resources/ntp4/bookmarks_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   var localStrings = new LocalStrings;
 
   /**
@@ skipping 366 matching lines @@
      * Invoked when a node has been added.
      * @param {string} id The id of the newly created bookmark node.
      * @param {Object} bookmark The new bookmark node.
      * @param {boolean} fromCurrentPage True if the action was from this page.
      */
     bookmarkNodeAdded: function(id, bookmark, fromCurrentPage) {
       if (this.importing) return;
       if (this.currentlyInFolder_(bookmark.parentId)) {
         // Hide the import promo if it exists.
         this.hideImportPromo_();
-        // If source of the add came from this page, show an animated insertion,
-        // otherwise just quietly do it.
-        this.addTileAt(new Bookmark(bookmark), bookmark.index, fromCurrentPage);
-        this.repositionTiles_();
+        // Only add the item if it should be visible.
+        if (bookmark.index < MAX_BOOKMARK_TILES) {
+          // If source of the add came from this page, show an animated
+          // insertion, otherwise just quietly do it.
+          this.addTileAt(new Bookmark(bookmark), bookmark.index,
+                         fromCurrentPage);
+          // Delete extra tiles if they exist.
+          while (this.tiles.length > MAX_BOOKMARK_TILES) {
+            var tile = this.tiles[this.tiles.length-1];

[Evan Stade, 2011/09/22 02:52:19]

spaces around operators

[csilv, 2011/09/22 17:07:01]

Done.

+            this.removeTile(tile, false);
+          }
+          this.repositionTiles_();
+        }
       }
     },
 
     /**
      * Invoked when the title or url of a node changes.
      * @param {string} id The id of the changed node.
      * @param {Object} changeInfo Details of the changed node.
      */
     bookmarkNodeChanged: function(id, changeInfo) {
       if (this.importing) return;
@@ skipping 233 matching lines @@
       tile.stripeColor = color;
   }
 
   return {
     BookmarksPage: BookmarksPage,
     initBookmarkChevron: initBookmarkChevron,
   };
 });
 
 window.addEventListener('load', ntp4.initBookmarkChevron);