Issue 7980061: [ntp4] Handle max tile limit properly when adding bookmarks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7980061: [ntp4] Handle max tile limit properly when adding bookmarks. (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] Handle max tile limit properly when adding bookmarks. BUG=97268 TEST=See bug for details. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102299

Patch Set 2 : code review tweak #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	chrome/browser/resources/ntp4/bookmarks_page.js	View	1	1 chunk	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm http://codereview.chromium.org/7980061/diff/1/chrome/browser/resources/ntp4/bookmarks_page.js File chrome/browser/resources/ntp4/bookmarks_page.js (right): http://codereview.chromium.org/7980061/diff/1/chrome/browser/resources/ntp4/bookmarks_page.js#newcode395 chrome/browser/resources/ntp4/bookmarks_page.js:395: var tile = this.tiles[this.tiles.length-1]; spaces around operators

9 years, 3 months ago (2011-09-22 02:52:19 UTC) #2

csilv

9 years, 3 months ago (2011-09-22 17:07:01 UTC) #3

http://codereview.chromium.org/7980061/diff/1/chrome/browser/resources/ntp4/b...
File chrome/browser/resources/ntp4/bookmarks_page.js (right):

http://codereview.chromium.org/7980061/diff/1/chrome/browser/resources/ntp4/b...
chrome/browser/resources/ntp4/bookmarks_page.js:395: var tile =
this.tiles[this.tiles.length-1];
On 2011/09/22 02:52:19, Evan Stade wrote:
> spaces around operators

Done.

Expand Messages | Collapse Messages

Issue 7980061: [ntp4] Handle max tile limit properly when adding bookmarks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review tweak #

Messages