Add about:flags entry to disable WebGL.

Add about:flags entry to disable WebGL.

http://crbug.com/87790
R=vangelis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102497

[vangelis, 2011-09-21 21:35:27]

http://codereview.chromium.org/7980047/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7980047/diff/1/chrome/browser/about_flags.cc#n...
chrome/browser/about_flags.cc:422: SINGLE_VALUE_TYPE(switches::kInProcessWebGL)
This is the wrong flag.  The one we need in order to disable WebGL is
kDisableExperimentalWebGL.  

What will be a bit confusing with the about:flags UI for this is that the flag
is a disable flag but you'll still need to click on the "Enable" button to
disable WebGL.  But that's the unfortunate side-effect of using about:flags for
such settings...

[tfarina, 2011-09-21 21:42:39]

http://codereview.chromium.org/7980047/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7980047/diff/1/chrome/browser/about_flags.cc#n...
chrome/browser/about_flags.cc:422: SINGLE_VALUE_TYPE(switches::kInProcessWebGL)
On 2011/09/21 21:35:27, vangelis wrote:
> This is the wrong flag.  The one we need in order to disable WebGL is
> kDisableExperimentalWebGL.  
> 
> What will be a bit confusing with the about:flags UI for this is that the flag
> is a disable flag but you'll still need to click on the "Enable" button to
> disable WebGL.  But that's the unfortunate side-effect of using about:flags
for
> such settings...
> 
> 

Done.

[Ken Russell (switch to Gerrit), 2011-09-21 21:43:39]

Since Vangelis is looking at this and I'm traveling on business, moving myself
to the CC: list.

[vangelis, 2011-09-21 22:50:37]

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:417: {
Ideally this should be moved to be close to the other gpu-related flags further
up in the list.

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:418: "disable-webg",
typo: webg

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:419: IDS_FLAGS_ENABLE_WEBGL_NAME,
The ID should be renamed to *DISABLE_WEBGL* to match what the actual command
line flag does.  The corresponding text should be adjusted as well.

[tfarina, 2011-09-21 22:56:23]

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:417: {
On 2011/09/21 22:50:37, vangelis wrote:
> Ideally this should be moved to be close to the other gpu-related flags
further
> up in the list.

Done.

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:418: "disable-webg",
On 2011/09/21 22:50:37, vangelis wrote:
> typo: webg

Done.

http://codereview.chromium.org/7980047/diff/4001/chrome/browser/about_flags.c...
chrome/browser/about_flags.cc:419: IDS_FLAGS_ENABLE_WEBGL_NAME,
On 2011/09/21 22:50:37, vangelis wrote:
> The ID should be renamed to *DISABLE_WEBGL* to match what the actual command
> line flag does.  The corresponding text should be adjusted as well.

Done.

[tfarina, 2011-09-22 19:13:10]

ping?

[vangelis, 2011-09-23 00:57:03]

lgtm