Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 7980029: Update screen locker UI to match webui login (Closed)

Created:
9 years, 3 months ago by oshima
Modified:
9 years, 2 months ago
Reviewers:
Nikita (slow), zel, karen
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org
Visibility:
Public.

Description

Update screen locker UI to match webui login remove all rounded corders in the pod. add 1x border around pod change background to c0c0c0. BUG=chromium-os:20652 TEST=see bug for new ui mock Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -62 lines) Patch
M chrome/browser/chromeos/login/background_view.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/user_view.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/username_view.cc View 2 chunks +1 line, -45 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
9 years, 3 months ago (2011-09-21 03:14:39 UTC) #1
zel
how about we do that color change only when --webui-login switch is present?
9 years, 3 months ago (2011-09-21 03:32:55 UTC) #2
oshima
So there is a chance that we may switch it back?
9 years, 3 months ago (2011-09-21 03:37:53 UTC) #3
zel
LGTM
9 years, 3 months ago (2011-09-21 03:43:38 UTC) #4
oshima
I'm fine to revert if necessary. +nikita who should know this change. Nikita, we're changing ...
9 years, 3 months ago (2011-09-21 23:43:04 UTC) #5
zel
Great. Please go ahead and land this. We will deal with the fallback if it ...
9 years, 3 months ago (2011-09-22 00:23:14 UTC) #6
commit-bot: I haz the power
Change committed as 102230
9 years, 3 months ago (2011-09-22 03:02:35 UTC) #7
oshima
Zel, requesting for R15 merge.
9 years, 2 months ago (2011-09-26 23:30:18 UTC) #8
oshima
9 years, 2 months ago (2011-09-26 23:37:15 UTC) #9
karen, requesting merge approval for R15.

Powered by Google App Engine
This is Rietveld 408576698