Issue 7980028: Ensure that TemplateURLs created from old database entries without sync_guids generate their own ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7980028: Ensure that TemplateURLs created from old database entries without sync_guids generate their own ... (Closed)

Created:
9 years, 3 months ago by SteveT

Modified:
9 years, 3 months ago

Reviewers:
sky, akalin

CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Ensure that TemplateURLs created from old database entries without sync_guids generate their own GUIDs. BUG=96992 TEST=Ensure that KeywordTableTest.KeywordWithEmptySyncGUID passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102119

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -1 line)			Patch
	M	chrome/browser/webdata/keyword_table.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/webdata/keyword_table_unittest.cc	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

SteveT

Fixing a bug around the new sync_guid field for TemplateURLs. Please have a look. Thanks!

9 years, 3 months ago (2011-09-21 00:09:38 UTC) #1

LGTM

nice!