Move some chrome-specific bits out of InProcessBrowserTest

Move some chrome-specific bits out of InProcessBrowserTest

This is a preparation for content_browsertests target.

BUG=90448
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102133

[sky, 2011-09-21 00:12:34]

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (left):

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:167: if
(!command_line->HasSwitch(kUnitTestShowWindows) && !show_window_)
Where are you going to move this code to?

[Paweł Hajdan Jr., 2011-09-21 01:01:08]

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (left):

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:167: if
(!command_line->HasSwitch(kUnitTestShowWindows) && !show_window_)
On 2011/09/21 00:12:34, sky wrote:
> Where are you going to move this code to?

I think this is not needed. Don't windows show by default? At least that's true
on Linux & Mac.

[sky, 2011-09-21 03:30:23]

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (left):

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:167: if
(!command_line->HasSwitch(kUnitTestShowWindows) && !show_window_)
On 2011/09/21 01:01:09, Paweł Hajdan Jr. wrote:
> On 2011/09/21 00:12:34, sky wrote:
> > Where are you going to move this code to?
> 
> I think this is not needed. Don't windows show by default? At least that's
true
> on Linux & Mac.

I believe they show by default, and this code is trying to make them hide. At
least that is my understanding of it.

[Paweł Hajdan Jr., 2011-09-21 16:36:37]

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
File chrome/test/base/in_process_browser_test.cc (left):

http://codereview.chromium.org/7980026/diff/1/chrome/test/base/in_process_bro...
chrome/test/base/in_process_browser_test.cc:167: if
(!command_line->HasSwitch(kUnitTestShowWindows) && !show_window_)
On 2011/09/21 03:30:23, sky wrote:
> On 2011/09/21 01:01:09, Paweł Hajdan Jr. wrote:
> > On 2011/09/21 00:12:34, sky wrote:
> > > Where are you going to move this code to?
> > 
> > I think this is not needed. Don't windows show by default? At least that's
> true
> > on Linux & Mac.
> 
> I believe they show by default, and this code is trying to make them hide. At
> least that is my understanding of it.

I have just verified this on Windows. The windows are _not_ hidden. Looks like
this code does not work.

In my opinion its removal is a good thing anyway. We shouldn't have big platform
differences for tests, and it doesn't work.

[sky, 2011-09-21 16:40:01]

Ok, LGTM

[jennb, 2011-09-21 16:48:07]

LGTM for panels changes.