src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c - Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c

Issue 7980021: Speed up x86-64 validator by inlining heavily called routines. Speeds up (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/x86/decoder/nc_inst_iter_inl.h ('K') | « src/trusted/validator/x86/ncval_reg_sfi/nc_jumps.c ('k') | src/trusted/validator/x86/ncval_reg_sfi/nc_memory_protect.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c

===================================================================

--- src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c (revision 6734)

+++ src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.c (working copy)

@@ -12,7 +12,7 @@

#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/nc_jumps_detailed.h"

#include "native_client/src/shared/platform/nacl_log.h"

-#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter.h"

+#include "native_client/src/trusted/validator/x86/decoder/nc_inst_iter_inl.h"

#include "native_client/src/trusted/validator/x86/decoder/nc_inst_state_internal.h"

#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter.h"

#include "native_client/src/trusted/validator/x86/ncval_reg_sfi/ncvalidate_iter_internal.h"

@@ -134,8 +134,9 @@

"Not enough memory to check jumps\n");

break;

}

- for (; NaClInstIterHasNext(check_iter); NaClInstIterAdvance(check_iter)) {

- NaClInstState* inst_state = NaClInstIterGetState(check_iter);

+ for (; NaClInstIterHasNextInline(check_iter);

+ NaClInstIterAdvanceInline(check_iter)) {

+ NaClInstState* inst_state = NaClInstIterGetStateInline(check_iter);

NaClInstLayoutCheck(state, inst_state, jump_sets);

}

NaClInstIterDestroy(check_iter);