Speed up x86-64 validator by inlining heavily called routines. Speeds up

src/trusted/validator/x86/x86_insts.c

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/trusted/validator/x86/x86_insts.h"
+#include "native_client/src/trusted/validator/x86/x86_insts_inl.h"
 
 /* Defines the range of possible (initial) opcodes for x87 instructions. */
 const uint8_t kFirstX87Opcode = 0xd8;
 const uint8_t kLastX87Opcode = 0xdf;
 
 /* Defines the opcode for the WAIT instruction.
  * Note: WAIT is an x87 instruction but not in the coproc opcode space.
  */
 const uint8_t kWAITOp = 0x9b;
 
 const uint8_t kTwoByteOpcodeByte1 = 0x0f;
 const uint8_t k3DNowOpcodeByte2 = 0x0f;
 const int kMaxPrefixBytes = 4;
 
 /* Accessors for the ModRm byte. */
-uint8_t modrm_mod(uint8_t modrm) { return ((modrm >> 6) & 0x03);}
-uint8_t modrm_rm(uint8_t modrm) { return (modrm & 0x07); }
-uint8_t modrm_reg(uint8_t modrm) { return ((modrm >> 3) & 0x07); }
-uint8_t modrm_opcode(uint8_t modrm) { return modrm_reg(modrm); }
+uint8_t modrm_mod(uint8_t modrm) {
+  return modrm_modInline(modrm);
+}
+
+uint8_t modrm_rm(uint8_t modrm) {
+  return modrm_rmInline(modrm);
+}
+
+uint8_t modrm_reg(uint8_t modrm) {
+  return modrm_regInline(modrm);
+}
+
+uint8_t modrm_opcode(uint8_t modrm) {
+  return modrm_opcodeInline(modrm);
+}
 
 /* Accessors for the Sib byte. */
 uint8_t sib_ss(uint8_t sib) { return ((sib >> 6) & 0x03); }
 uint8_t sib_index(uint8_t sib) { return ((sib >> 3) & 0x07); }
 uint8_t sib_base(uint8_t sib) { return (sib & 0x07); }
 
 /* Defines the corresponding mask for the bits of the the Rex prefix. */
 #define NaClRexWMask 0x8
 #define NaClRexRMask 0x4
 #define NaClRexXMask 0x2
@@ skipping 11 matching lines @@
   return NaClHasBit(prefix, NaClRexRMask);
 }
 
 uint8_t NaClRexX(uint8_t prefix) {
   return NaClHasBit(prefix, NaClRexXMask);
 }
 
 uint8_t NaClRexB(uint8_t prefix) {
   return NaClHasBit(prefix, NaClRexBMask);
 }