Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 7980013: After a successful ping of the RLZ server, make sure to update the cached (Closed)

Created:
9 years, 3 months ago by Roger Tawa OOO till Jul 10th
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

After a successful ping of the RLZ server, make sure to update the cached RLZ strings for the omnibox and home page access points instead of just invalidating, so that the first time the code tries to use the strings after the ping they are valid. BUG=None TEST=Install chrome. Chrome will start automatically, do not stop it. Wait for the RLZ ping to be sent. Perform a search with the omnibox and make sure an rlz= CGI parameter is present. Visit the home page and make the request contains an X-Rlz-String HTTP header. To perform these tests, install an official chrome build with a non-organic brand code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -23 lines) Patch
M chrome/browser/rlz/rlz.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 8 chunks +36 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
9 years, 3 months ago (2011-09-20 17:45:33 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
9 years, 3 months ago (2011-09-22 01:37:35 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/receiver/rogerta%40chromium.org/7980013/1
9 years, 3 months ago (2011-09-22 13:31:24 UTC) #3
commit-bot: I haz the power
List of reviewers changed.
9 years, 3 months ago (2011-09-22 15:17:00 UTC) #4
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/rogerta%40chromium.org/7980013/1
9 years, 3 months ago (2011-09-22 17:05:40 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 18:44:28 UTC) #6
Change committed as 102321

Powered by Google App Engine
This is Rietveld 408576698