Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 7980004: GcSafeCastToCode should not use Code::contains it is not evacuation safe. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

GcSafeCastToCode should not use Code::contains it is not evacuation safe. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=9345

Patch Set 1 #

Patch Set 2 : fix holder->contains() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M src/frames.cc View 1 2 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-20 12:54:43 UTC) #1
Erik Corry
LGTM
9 years, 3 months ago (2011-09-20 13:04:10 UTC) #2
Erik Corry
9 years, 3 months ago (2011-09-20 13:20:12 UTC) #3
On 2011/09/20 13:04:10, Erik Corry wrote:
> LGTM

LEBTM

Powered by Google App Engine
This is Rietveld 408576698