Issue 7979038: Fix transferal of marking bits on array trimming.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7979038: Fix transferal of marking bits on array trimming. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger

Modified:
9 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix transferal of marking bits on array trimming. R=vegorov@chromium.org BUG=v8:1708 TEST=mjsunit/regress/regress-1708 Committed: http://code.google.com/p/v8/source/detail?r=9394

Patch Set 2 : Addressed comments by Vyacheslav Egorov. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -23 lines)			Patch
	M	src/mark-compact.cc	View	1	3 chunks	+28 lines, -23 lines	0 comments	Download
	A	test/mjsunit/regress/regress-1708.js	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/7979038/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7979038/diff/1/src/mark-compact.cc#newcode388 src/mark-compact.cc:388: old_mark_bit.Next().Clear(); should not we clear both bits? (grey ...

9 years, 3 months ago (2011-09-22 11:59:02 UTC) #2

Michael Starzinger

9 years, 3 months ago (2011-09-22 13:03:02 UTC) #3

Added new patch set.

http://codereview.chromium.org/7979038/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/7979038/diff/1/src/mark-compact.cc#newcode388
src/mark-compact.cc:388: old_mark_bit.Next().Clear();
On 2011/09/22 11:59:02, Vyacheslav Egorov wrote:
> should not we clear both bits? (grey = 11)

Done. You are right, didn't look into the grey case close enough. Nice catch!

Expand Messages | Collapse Messages

Issue 7979038: Fix transferal of marking bits on array trimming. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Vyacheslav Egorov. #

Messages