Fix for black-hole.

Fix for black-hole on views desktop with compositor.
 Child widget should not be parented to desktop.
 This was causing tab contents for prerendering be parented to desktop.
Fix for DCHECK failure in NativeWidgetViews::OnKeyEvent
 Child widget should not be activated.
Reset non_client_view_ when new contentview is set.

BUG=none
TEST=updated widget_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102389

[sadrul, 2011-09-22 16:37:24]

LGTM

[oshima, 2011-09-22 22:06:15]

Scott, I had to fix tests after sadrul lgtm'ed.
Can you review this?

[sadrul, 2011-09-22 22:12:04]

LGTM with a note

http://codereview.chromium.org/7979035/diff/13004/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7979035/diff/13004/views/widget/widget.cc#newc...
views/widget/widget.cc:403: non_client_view_ = NULL;
If this is necessary only for tests, can there be some check that for non-tests
to make sure this is not called? I am not sure if it is desirable to restrict
doing this for normal cases.

[oshima, 2011-09-22 22:27:05]

http://codereview.chromium.org/7979035/diff/13004/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7979035/diff/13004/views/widget/widget.cc#newc...
views/widget/widget.cc:403: non_client_view_ = NULL;
On 2011/09/22 22:12:04, sadrul wrote:
> If this is necessary only for tests, can there be some check that for
non-tests
> to make sure this is not called? I am not sure if it is desirable to restrict
> doing this for normal cases.

This is a bug which has to be fixed in normal case as well. When we reset the
content view to something else, non_client_view_ is no longer valid and has to
be set to NULL. (although there is no place in browser code that does this.)

[sky, 2011-09-22 22:35:43]

LGTM