Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 7979034: Add --count support. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add --count support. Output details to stderr to make it redirect-friendly. Silence upload.py. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102277

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix typo #

Patch Set 3 : Rebase against HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M my_reviews.py View 1 2 3 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-22 00:59:53 UTC) #1
Dirk Pranke
lgtm http://codereview.chromium.org/7979034/diff/1/my_reviews.py File my_reviews.py (right): http://codereview.chromium.org/7979034/diff/1/my_reviews.py#newcode88 my_reviews.py:88: help='Use last quarter dates as filter') Nit: "last ...
9 years, 3 months ago (2011-09-22 01:13:15 UTC) #2
commit-bot: I haz the power
Can't apply patch for file depot_tools/my_reviews.py. While running patch -p1 --forward --force; patching file depot_tools/my_reviews.py ...
9 years, 3 months ago (2011-09-22 01:18:27 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/receiver/maruel%40chromium.org/7979034/6001
9 years, 3 months ago (2011-09-22 15:16:19 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 15:22:07 UTC) #5
Change committed as 102277

Powered by Google App Engine
This is Rietveld 408576698