Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 7979021: Adds a trivial menu to WindowTypeLauncher. This was more for me to (Closed)

Created:
9 years, 3 months ago by sky
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adds a trivial menu to WindowTypeLauncher. This was more for me to make sure menus are shown rather then something meaningful. BUG=none TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102180

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M ui/aura_shell/examples/window_type_launcher.h View 3 chunks +21 lines, -2 lines 0 comments Download
M ui/aura_shell/examples/window_type_launcher.cc View 4 chunks +34 lines, -6 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
sky
9 years, 3 months ago (2011-09-21 16:03:27 UTC) #1
Ben Goodger (Google)
LGTM http://codereview.chromium.org/7979021/diff/1/ui/aura_shell/examples/window_type_launcher.cc File ui/aura_shell/examples/window_type_launcher.cc (right): http://codereview.chromium.org/7979021/diff/1/ui/aura_shell/examples/window_type_launcher.cc#newcode67 ui/aura_shell/examples/window_type_launcher.cc:67: return true; Not a comment on this CL ...
9 years, 3 months ago (2011-09-21 16:10:28 UTC) #2
sky
9 years, 3 months ago (2011-09-21 16:31:30 UTC) #3
On Wed, Sep 21, 2011 at 9:10 AM, <ben@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.**org/7979021/diff/1/ui/aura_**
>
shell/examples/window_type_**launcher.cc<http://codereview.chromium.org/7979021/diff/1/ui/aura_shell/examples/window_type_launcher.cc>
> File ui/aura_shell/examples/window_**type_launcher.cc (right):
>
> http://codereview.chromium.**org/7979021/diff/1/ui/aura_**
>
shell/examples/window_type_**launcher.cc#newcode67<http://codereview.chromium.org/7979021/diff/1/ui/aura_shell/examples/window_type_launcher.cc#newcode67>
> ui/aura_shell/examples/window_**type_launcher.cc:67: return true;
> Not a comment on this CL per se, but remember the other day when I was
> griping about having to override OnMousePressed to return true so that I
> could receive OnMouseReleased and how it was confusing? You know what's
> even more confusing - having to override OnMousePressed so that context
> menus work :-)
>
>
I shook my fist in anger this morning too!

  -Scott

Powered by Google App Engine
This is Rietveld 408576698