Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 7978055: Speak the name of the image selection screen when it's activated, if accessibility is turned on (Closed)

Created:
9 years, 3 months ago by Zachary Kuznia
Modified:
9 years, 3 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Speak the name of the image selection screen when it's activated, if accessibility is turned on R=hashimoto@chromium.org BUG=chromium-os:18955 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102272

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change atomic to assertive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_user_image.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zachary Kuznia
9 years, 3 months ago (2011-09-22 07:33:12 UTC) #1
hashimoto
http://codereview.chromium.org/7978055/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html File chrome/browser/resources/chromeos/login/oobe_screen_user_image.html (right): http://codereview.chromium.org/7978055/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_user_image.html#newcode2 chrome/browser/resources/chromeos/login/oobe_screen_user_image.html:2: <div id="user-image-aria-label" aria-live="polite" aria-atomic="true"></div> Is aria-atomic necessary here?
9 years, 3 months ago (2011-09-22 09:05:38 UTC) #2
Zachary Kuznia
A fine point. Changed to using assertive instead of atomic. On Thu, Sep 22, 2011 ...
9 years, 3 months ago (2011-09-22 09:09:55 UTC) #3
hashimoto
lgtm
9 years, 3 months ago (2011-09-22 09:13:51 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-22 14:28:08 UTC) #5
Change committed as 102272

Powered by Google App Engine
This is Rietveld 408576698