Sync/Valgrind: Add gmock printers for SyncChange, SyncData, SyncError.

chrome/browser/sync/api/sync_error.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/api/sync_error.h"
 
+#include <iostream>

[akalin, 2011/09/22 01:24:56]

iostream -> ostream (former introduces a static intializer, iirc)

[James Hawkins, 2011/09/22 02:50:29]

Done.

+#include <sstream>
+
 #include "base/logging.h"
 #include "base/tracked.h"
+#include "chrome/browser/sync/syncable/model_type.h"
 
 SyncError::SyncError() {
   Clear();
 }
 
 SyncError::SyncError(const tracked_objects::Location& location,
                      const std::string& message,
                      syncable::ModelType type) {
   Init(location, message, type);
   PrintLogError();
@@ skipping 57 matching lines @@
 const std::string& SyncError::message() const {
   CHECK(IsSet());
   return message_;
 }
 
 syncable::ModelType SyncError::type() const {
   CHECK(IsSet());
   return type_;
 }
 
+std::string SyncError::ToString() const {
+  std::string out;
+  std::stringstream ss(out, std::stringstream::in);

[akalin, 2011/09/22 01:24:56]

You don't really need a stringstream, do you?  Just build up the returned string
by concatenating

[James Hawkins, 2011/09/22 02:50:29]

I don't print IsSet() anymore, so I changed it back to string concat.

+  ss <<
+      "{" << location_->ToString() <<

[akalin, 2011/09/22 01:24:56]

type() and message() CHECK IsSet().  Suggest:

if (IsSet()) {
  return "{" + location_->ToString() + ... + "}";
} else {
  return "<unset SyncError>";
}

[James Hawkins, 2011/09/22 02:50:29]

Done.

+      ", " << IsSet() <<
+      ", " << syncable::ModelTypeToString(type()) <<
+      ", " << message() <<
+      "}";
+  return out;
+}
+
 void SyncError::PrintLogError() const {
   LAZY_STREAM(logging::LogMessage(location_->file_name(),
                                   location_->line_number(),
                                   logging::LOG_ERROR).stream(),
               LOG_IS_ON(ERROR))
       << syncable::ModelTypeToString(type_) << " Sync Error: " << message_;
 }
+
+void PrintTo(const SyncError& sync_error, std::ostream* os) {
+  *os << sync_error.ToString();
+}