Sync/Valgrind: Add gmock printers for SyncChange, SyncData, SyncError.

chrome/browser/sync/api/sync_change.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_API_SYNC_CHANGE_H_
 #define CHROME_BROWSER_SYNC_API_SYNC_CHANGE_H_
 #pragma once
 
+#include <iosfwd>
 #include <string>
 #include <vector>
 
 #include "chrome/browser/sync/api/sync_data.h"
 
 // A SyncChange object reflects a change to a piece of synced data. The change
 // can be either a delete, add, or an update. All data relevant to the change
 // is encapsulated within the SyncChange, which, once created, is immutable.
 // Note: it is safe and cheap to pass these by value or make copies, as they do
 // not create deep copies of their internal data.
@@ skipping 30 matching lines @@
   static std::string ChangeTypeToString(SyncChangeType change_type);
 
  private:
   SyncChangeType change_type_;
 
   // An immutable container for the data of this SyncChange. Whenever
   // SyncChanges are copied, they copy references to this data.
   SyncData sync_data_;
 };
 
+// Printing operator - helps gtest produce readable error messages.
+std::ostream& operator<<(std::ostream& os, const SyncChange& sync_change);

[akalin, 2011/09/21 23:12:58]

This is against Google style.  I'd prefer to add 'const std::string ToString()
const' member functions to SyncChange etc. and also define PrintTo() for gtest
as described in http://code.google.com/p/googletest/wiki/AdvancedGuide .

[James Hawkins, 2011/09/22 01:15:26]

Done.

+
 #endif  // CHROME_BROWSER_SYNC_API_SYNC_CHANGE_H_