Additional update on Pepper IME API and boilerplate thunk/proxy implementation.

ppapi/proxy/ppb_text_input_proxy.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_PPB_TEXT_INPUT_PROXY_H_
+#define PPAPI_PPB_TEXT_INPUT_PROXY_H_
+
+#include "ppapi/c/pp_completion_callback.h"

[yzshen1, 2011/09/22 19:24:00]

Please only include those that are necessary.
There are quite a few that can be removed.

[kinaba, 2011/09/27 02:49:27]

Done.

+#include "ppapi/c/pp_bool.h"
+#include "ppapi/c/pp_instance.h"
+#include "ppapi/c/pp_point.h"
+#include "ppapi/c/pp_resource.h"
+#include "ppapi/proxy/interface_proxy.h"
+#include "ppapi/shared_impl/function_group_base.h"
+#include "ppapi/shared_impl/host_resource.h"
+#include "ppapi/thunk/ppb_text_input_api.h"
+
+struct PPB_TextInput_Dev;
+
+namespace ppapi {
+namespace proxy {
+
+class PPB_TextInput_Proxy
+    : public InterfaceProxy,
+      public ppapi::thunk::PPB_TextInput_FunctionAPI {
+ public:
+  PPB_TextInput_Proxy(Dispatcher* dispatcher);
+  virtual ~PPB_TextInput_Proxy();
+
+  // FunctionGroupBase overrides.
+  ppapi::thunk::PPB_TextInput_FunctionAPI* AsPPB_TextInput_FunctionAPI()
+      OVERRIDE;
+
+  // PPB_TextInput_FunctionAPI implementation.
+  virtual void SetTextInputType(PP_Instance instance,
+                                PP_TextInput_Type type) OVERRIDE;
+  virtual void UpdateCaretPosition(PP_Instance instance,
+                                   const PP_Rect& caret,
+                                   const PP_Rect& boundingBox) OVERRIDE;

[yzshen1, 2011/09/22 19:24:00]

Use bounding_box, please. (line 53 has the same problem.)

[kinaba, 2011/09/27 02:49:27]

Done. Sorry for repeating the same mistake...

+  virtual void ConfirmCompositionText(PP_Instance instance) OVERRIDE;
+  virtual void CancelCompositionText(PP_Instance instance) OVERRIDE;
+
+  // InterfaceProxy implementation.
+  virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
+
+  static const InterfaceID kInterfaceID = INTERFACE_ID_PPB_TEXT_INPUT;
+
+ private:
+  // Message handlers.
+  void OnMsgSetTextInputType(PP_Instance instance, PP_TextInput_Type type);
+  void OnMsgUpdateCaretPosition(PP_Instance instance,
+                                PP_Rect caret,
+                                PP_Rect boundingBox);
+  void OnMsgConfirmCompositionText(PP_Instance instance);
+  void OnMsgCancelCompositionText(PP_Instance instance);
+
+  DISALLOW_COPY_AND_ASSIGN(PPB_TextInput_Proxy);
+};
+
+}  // namespace proxy
+}  // namespace ppapi
+
+#endif  // PPAPI_PPB_TEXT_INPUT_PROXY_H_