Don't call OnNativeWidgetVisibilityChange in NativeWidgetGtk

views/widget/native_widget_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkx.h>
 #include <X11/extensions/shape.h>
 #include <X11/Xatom.h>
@@ skipping 1148 matching lines @@
 
 void NativeWidgetGtk::EnableClose(bool enable) {
   gtk_window_set_deletable(GetNativeWindow(), enable);
 }
 
 void NativeWidgetGtk::Show() {
   if (widget_) {
     gtk_widget_show(widget_);
     if (widget_->window)
       gdk_window_raise(widget_->window);
-    delegate_->OnNativeWidgetVisibilityChanged(true);
+    // See Hide() for the reason why we're not calling
+    // OnNativeWidgetVisibilityChange.
   }
 }
 
 void NativeWidgetGtk::Hide() {
   if (widget_) {
     gtk_widget_hide(widget_);
     if (widget_->window)
       gdk_window_lower(widget_->window);
-    delegate_->OnNativeWidgetVisibilityChanged(false);
+    // We're not calling OnNativeWidgetVisibilityChanged because it
+    // breaks the ability to refocus to FindBar. NativeControlGtk
+    // detaches the underlying gtk widget for optimization purpose
+    // when it becomes invisible, which in turn breaks SetNativeFocus
+    // because there is no gtk attached to NativeControlGtk. I'm not
+    // fixing that part because
+    // a) This is views/gtk only issue, which will be gone soon.
+    // b) Alternative fix, which we can modify animator to show it
+    // immediately, won't be necessary for non gtk implementation.
   }
 }
 
 void NativeWidgetGtk::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   // TODO: when we add maximization support update this.
   Show();
 }
 
 void NativeWidgetGtk::ShowWithWindowState(ui::WindowShowState show_state) {
@@ skipping 1073 matching lines @@
     button_pressed = event->type == GDK_BUTTON_PRESS ||
         event->type == GDK_2BUTTON_PRESS ||
         event->type == GDK_3BUTTON_PRESS;
     gdk_event_free(event);
   }
   return button_pressed;
 }
 
 }  // namespace internal
 }  // namespace views