Possible workaround for bug with loading pages in a background tab

Fix for bug with pages loading in a background tab.

Occasionally, chrome would segfault when a background tab was loading.  I was running into this issue quite often when testing opening many tabs.


BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102123

[sadrul, 2011-09-21 04:06:11]

+oshima

I think this CL makes sense: with the change to make the TCV a Widget, GetWidget
in RWHVV will not be NULL anymore for a background tab, but I suspect
GetWidget->GetNativeView still could be NULL?

http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:993: 
-newline

[oshima, 2011-09-21 04:21:49]

LGTM with one request.


Yes, this make sense. NWVs::GetNativeView on views desktop is currently broken
(and no plan to fix as we're moving to aura) because it returns desktop's native
view, so if it's detached from view hierarchy, it returns NULL.

http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:991: else
can you move #end here so that aura can get default screen info?

[mmocny, 2011-09-21 14:10:57]

Done.

On 2011/09/21 04:21:49, oshima wrote:
> LGTM with one request.
> 
> 
> Yes, this make sense. NWVs::GetNativeView on views desktop is currently broken
> (and no plan to fix as we're moving to aura) because it returns desktop's
native
> view, so if it's detached from view hierarchy, it returns NULL.
> 
>
http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
> File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):
> 
>
http://codereview.chromium.org/7978011/diff/1/chrome/browser/renderer_host/re...
> chrome/browser/renderer_host/render_widget_host_view_views.cc:991: else
> can you move #end here so that aura can get default screen info?

[sadrul, 2011-09-21 14:14:18]

LGTM.

Please update the description to briefly state what the fix is for (i.e. what
was broken, why etc.) in a couple of sentences. It makes life easier when going
through the logs.

[commit-bot: I haz the power, 2011-09-21 17:12:15]

Change committed as 102123