Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 7977046: Revert 102215 - Pull libcros v173 (Closed)

Created:
9 years, 3 months ago by tommi (sloooow) - chröme
Modified:
9 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Revert 102215 - Pull libcros v173 Lots of functions have been deprecated recently. We should update the DEPS and wait for a while before removing them. BUG=chromium-os:20648 TEST=build chrome Review URL: http://codereview.chromium.org/7980030 TBR=satorux@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/cros.DEPS/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
9 years, 3 months ago (2011-09-22 10:01:03 UTC) #1
tommi (sloooow) - chröme
9 years, 3 months ago (2011-09-22 10:40:28 UTC) #2
fyi - this revert has been reverted!  (i.e. I checked your change in again)

On Thu, Sep 22, 2011 at 12:01 PM, <tommi@chromium.org> wrote:

> Reviewers: satorux1,
>
> Description:
> Revert 102215 - Pull libcros v173
>
> Lots of functions have been deprecated recently.
> We should update the DEPS and wait for a while before
> removing them.
>
> BUG=chromium-os:20648
> TEST=build chrome
>
> Review URL:
http://codereview.chromium.**org/7980030<http://codereview.chromium.org/7980030>
>
> TBR=satorux@chromium.org
>
> Please review this at
http://codereview.chromium.**org/7977046/<http://codereview.chromium.org/7977...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     tools/cros.DEPS/DEPS
>
>
> Index: tools/cros.DEPS/DEPS
> ==============================**==============================**=======
> --- tools/cros.DEPS/DEPS        (revision 102258)
> +++ tools/cros.DEPS/DEPS        (working copy)
> @@ -5,7 +5,7 @@
>  deps_os = {
>   "unix" : {
>     "src/third_party/cros":
> -      Var("chromiumos_git") + "/platform/cros.git@69a693ab",
> +      Var("chromiumos_git") + "/platform/cros.git@3daf7b80",
>     "src/third_party/cros_system_**api":
>       Var("chromiumos_git") + "/platform/system_api.git@**c3de536a",
>   }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698