Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 7977042: Get rid of synchronous calls to getting plugins to help with http://codereview.chromium.org/79800... (Closed)

Created:
9 years, 3 months ago by jam
Modified:
9 years, 3 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr., Bernhard Bauer
Visibility:
Public.

Description

Get rid of synchronous calls to getting plugins to help with http://codereview.chromium.org/7980011/. The PluginExceptionsTableModel isn't used anymore. Change print preview and using Reader with unsupported PDFs to tell the plugin filter which plugin name they want to use, instead of giving it the plugin directly. This makes the former not need to block on getting the plugins. The later still does, to know if Reader is installed or not, however it's trivial to make PDFHasUnsupportedFeature() get the plugins asynchronously because it's just a dispatcher for an async message. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102284

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -601 lines) Patch
M chrome/browser/chrome_plugin_service_filter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chrome_plugin_service_filter.cc View 4 chunks +15 lines, -6 lines 0 comments Download
D chrome/browser/mock_plugin_exceptions_table_model.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/mock_plugin_exceptions_table_model.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/pdf_unsupported_feature.cc View 1 chunk +1 line, -7 lines 0 comments Download
D chrome/browser/plugin_exceptions_table_model.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/plugin_exceptions_table_model.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/plugin_exceptions_table_model_unittest.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 chunk +2 lines, -26 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 3 months ago (2011-09-22 02:28:47 UTC) #1
Robert Sesek
9 years, 3 months ago (2011-09-22 13:37:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698