Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 7977041: Fix unittest-only leak in ExtensionSettingsUIWrapper. (Closed)

Created:
9 years, 3 months ago by not at google - send to devlin
Modified:
9 years, 3 months ago
Reviewers:
oshima, akalin
CC:
chromium-reviews, Alexander Potapenko, Erik does not do reviews, Timur Iskhodzhanov, mihaip+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Fix unittest-only leak in ExtensionSettingsUIWrapper. BUG=97511 TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M chrome/browser/extensions/extension_settings_ui_wrapper.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
Here's another one (2 of 3). This leak happens because those unit tests aren't processing ...
9 years, 3 months ago (2011-09-22 00:59:11 UTC) #1
akalin
On 2011/09/22 00:59:11, kalman1 wrote: > Here's another one (2 of 3). > > This ...
9 years, 3 months ago (2011-09-22 01:12:18 UTC) #2
akalin
Putting through trybots and committing from http://codereview.chromium.org/7976043/
9 years, 3 months ago (2011-09-22 01:13:15 UTC) #3
akalin
9 years, 3 months ago (2011-09-22 05:44:56 UTC) #4
On 2011/09/22 01:13:15, akalin wrote:
> Putting through trybots and committing from
> http://codereview.chromium.org/7976043/

Committed as 102245

Powered by Google App Engine
This is Rietveld 408576698