chrome/browser/ui/panels/panel_browser_view_browsertest.cc - Issue 7977037: Refactor Win panel mouse watcher to use PanelMouseWatcher base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

Issue 7977037: Refactor Win panel mouse watcher to use PanelMouseWatcher base class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_browser_view_browsertest.cc

===================================================================

--- chrome/browser/ui/panels/panel_browser_view_browsertest.cc (revision 102199)

+++ chrome/browser/ui/panels/panel_browser_view_browsertest.cc (working copy)

@@ -12,7 +12,7 @@

#include "chrome/browser/ui/panels/panel_browser_frame_view.h"

#include "chrome/browser/ui/panels/panel_browser_view.h"

#include "chrome/browser/ui/panels/panel_manager.h"

-#include "chrome/browser/ui/panels/panel_mouse_watcher_win.h"

+#include "chrome/browser/ui/panels/panel_mouse_watcher.h"

#include "chrome/browser/web_applications/web_app.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

@@ -126,7 +126,7 @@

EXPECT_LT(panel1->GetBounds().height(), titlebar_height);

EXPECT_GT(panel1->GetBounds().height(), 0);

EXPECT_EQ(expected_bottom_on_minimized, panel1->GetBounds().bottom());

- EXPECT_TRUE(IsMouseWatcherStarted());

+ EXPECT_TRUE(PanelMouseWatcher::GetInstance()->IsSubscribed(browser_view1));

WaitTillBoundsAnimationFinished(browser_view1);

EXPECT_FALSE(panel1->IsActive());

@@ -209,11 +209,8 @@

browser_view1->OnTitlebarMouseReleased();

panel1->Close();

- EXPECT_TRUE(IsMouseWatcherStarted());

panel2->Close();

- EXPECT_TRUE(IsMouseWatcherStarted());

panel3->Close();

- EXPECT_FALSE(IsMouseWatcherStarted());

}

void TestDrawAttention() {