Refactor Win panel mouse watcher to use PanelMouseWatcher base class.

Refactor Win panel mouse watcher to use PanelMouseWatcher base class.

BUG=None
TEST=Panel minimize and restore tests.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102616

(Original commit reverted in 102395.)

[jianli, 2011-09-22 00:48:33]

LGTM w/ a few nits.

http://codereview.chromium.org/7977037/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_mouse_watcher_win.cc (right):

http://codereview.chromium.org/7977037/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_mouse_watcher_win.cc:32: ~PanelMouseWatcherWin();
Please add virtual.

http://codereview.chromium.org/7977037/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_mouse_watcher_win.cc:34: virtual void Start();
Please add OVERRIDE.

http://codereview.chromium.org/7977037/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_mouse_watcher_win.cc:35: virtual void Stop();
ditto.

[commit-bot: I haz the power, 2011-09-22 16:51:08]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/jennb%40chromium.org/7977037/8

[prasadt, 2011-09-22 18:36:41]

http://codereview.chromium.org/7977037/diff/8/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_view_browsertest.cc (right):

http://codereview.chromium.org/7977037/diff/8/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view_browsertest.cc:100: void
TestMinimizeAndRestore(bool enable_auto_hiding) {
Do we still need this test now that PanelBrowserTest::MinimizeRestore is enabled
for windows?

[jennb, 2011-09-22 18:41:38]

Yes, we still need that test as it supports auto-hiding, which
PanelBrowserTest::MinimizeRestore does not. After auto-hiding is implemented
on non-Windows platforms, this test can be ported to PanelBrowserTest.

On Thu, Sep 22, 2011 at 11:36 AM, <prasadt@chromium.org> wrote:

>
> http://codereview.chromium.**org/7977037/diff/8/chrome/**
>
browser/ui/panels/panel_**browser_view_browsertest.cc<http://codereview.chromium.org/7977037/diff/8/chrome/browser/ui/panels/panel_browser_view_browsertest.cc>
> File chrome/browser/ui/panels/**panel_browser_view_**browsertest.cc
> (right):
>
> http://codereview.chromium.**org/7977037/diff/8/chrome/**
>
browser/ui/panels/panel_**browser_view_browsertest.cc#**newcode100<http://codereview.chromium.org/7977037/diff/8/chrome/browser/ui/panels/panel_browser_view_browsertest.cc#newcode100>
> chrome/browser/ui/panels/**panel_browser_view_**browsertest.cc:100: void
> TestMinimizeAndRestore(bool enable_auto_hiding) {
> Do we still need this test now that PanelBrowserTest::**MinimizeRestore is
> enabled for windows?
>
>
>
http://codereview.chromium.**org/7977037/<http://codereview.chromium.org/7977...
>

[commit-bot: I haz the power, 2011-09-22 20:26:56]

List of reviewers changed.

[Nirnimesh, 2011-09-23 02:01:10]

This broke PanelBrowserTest.MinimizeRestore. Failure is repeatable.

[jennb, 2011-09-23 23:34:03]

On 2011/09/23 02:01:10, Nirnimesh wrote:
> This broke PanelBrowserTest.MinimizeRestore. Failure is repeatable.

Re-committed patch with PanelBrowserTest.MinimizeRestore disabled for Windows.
Will investigate XP and Vista failures separately.