Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 7977034: Revert 102184 - [Sync] use base::Time in sync (Closed)

Created:
9 years, 3 months ago by akalin
Modified:
9 years, 3 months ago
Reviewers:
akalin
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Revert 102184 - [Sync] use base::Time in sync Make EntryKernel/Entry/BaseNode use base::Time instead of int64s. Add sync/util/time.h, with utility functions to manage the sync proto time format. Store times on disk in proto format instead of the local system. This requires a database version bump (to 77). Update SessionChangeProcessor/SessionModelAssociator to use base::Time, too. Remove hackish Now() function. Remove ZeroFields() function, and instead zero-initialize in EntryKernel::EntryKernel() directly. BUG= TEST= Review URL: http://codereview.chromium.org/7981006 TBR=akalin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -885 lines) Patch
M chrome/browser/sync/engine/build_commit_command.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/syncer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.h View 2 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/internal_api/base_node.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/base_node.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/sessions/sync_session_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.cc View 9 chunks +12 lines, -54 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store_unittest.cc View 20 chunks +236 lines, -598 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 10 chunks +14 lines, -40 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 10 chunks +54 lines, -30 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_columns.h View 2 chunks +6 lines, -6 lines 0 comments Download
MM chrome/browser/sync/syncable/syncable_enum_conversions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_enum_conversions.cc View 1 chunk +3 lines, -13 lines 0 comments Download
MM chrome/browser/sync/syncable/syncable_enum_conversions_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
MM chrome/browser/sync/syncable/syncable_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
MM chrome/browser/sync/util/sqlite_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/sync/util/time.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/sync/util/time.cc View 1 chunk +0 lines, -24 lines 0 comments Download
MM chrome/chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
akalin
9 years, 3 months ago (2011-09-21 22:56:23 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698