Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 7977030: Add my_reviews.py script for perf time. (Closed)

Created:
9 years, 3 months ago by M-A Ruel
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add my_reviews.py script for perf time. Add search interface for rietveld. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102191

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments #

Total comments: 1

Patch Set 3 : Remove comments #

Patch Set 4 : another comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -0 lines) Patch
A my_reviews.py View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
M rietveld.py View 1 chunk +58 lines, -0 lines 0 comments Download
M tests/rietveld_test.py View 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
9 years, 3 months ago (2011-09-21 20:24:36 UTC) #1
Dirk Pranke
I'm not actually convinced that this is useful enough to keep in the depot, but ...
9 years, 3 months ago (2011-09-21 20:44:18 UTC) #2
M-A Ruel
Please take another look. I played with the idea to move this into tools/ subdirectory, ...
9 years, 3 months ago (2011-09-21 20:54:11 UTC) #3
Dirk Pranke
http://codereview.chromium.org/7977030/diff/3001/my_reviews.py File my_reviews.py (right): http://codereview.chromium.org/7977030/diff/3001/my_reviews.py#newcode55 my_reviews.py:55: # 'subject' I think I wasn't clear. You list ...
9 years, 3 months ago (2011-09-21 21:05:42 UTC) #4
Marc-Antoine Ruel (Google)
On 2011/09/21 21:05:42, Dirk Pranke wrote: > my_reviews.py:55: # 'subject' > I think I wasn't ...
9 years, 3 months ago (2011-09-21 22:47:12 UTC) #5
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 3 months ago (2011-09-21 22:47:24 UTC) #6
Dirk Pranke
lgtm
9 years, 3 months ago (2011-09-21 23:10:03 UTC) #7
commit-bot: I haz the power
9 years, 3 months ago (2011-09-21 23:16:14 UTC) #8
Change committed as 102191

Powered by Google App Engine
This is Rietveld 408576698