Never submit: tentative Pepper IME.

Never submit: tentative Pepper IME.

BUG=
TEST=

[James Su, 2011-09-23 01:46:47]

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:851: }
nit: no { }

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:859:
render_view_->PpapiPluginFocusChanged();
Is it correct? Shouldn't we have a specific method for text input type change?

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:879:
focused_plugin_->HandleCompositionEnd(text);
should send composition_text_ along with composition end event? compositionend
event defined in HTML DOM Event Level3 has such behavior.

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:884: selection_start,
selection_end);
nit: use {} for multi-line if statement.

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:894: if (!CanComposeInline()) {
Is it possible that a plugin cannot handle inline composition but can handle
text input event? Or do we plan to support it?

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:907: }
nit: no line break.

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:910:
focused_plugin_->HandleCompositionEnd(composition_text_);
Should we send composition end first? Like what webkit does?

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.cc:1119: return focused_plugin_ !=
0;
!= NULL?

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
File content/renderer/pepper_plugin_delegate_impl.h (right):

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.h:172: WebKit::WebRect
GetCaretBounds() const;
should we use ui::Rect here?

http://codereview.chromium.org/7977017/diff/1/content/renderer/pepper_plugin_...
content/renderer/pepper_plugin_delegate_impl.h:173: WebKit::WebTextInputType
GetTextInputType() const;
should we use ui::TextInputType here?

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.cc
File content/renderer/render_view.cc (right):

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:4290: }
nit: no {}

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:4310: return RenderWidget::GetCaretBounds();
nit: return ... ? ... : ... ;

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.cc...
content/renderer/render_view.cc:4315: return
pepper_delegate_.CanComposeInline();
ditto.

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.h
File content/renderer/render_view.h (right):

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.h#...
content/renderer/render_view.h:661: virtual WebKit::WebTextInputType
GetTextInputType() OVERRIDE;
I think we should use ui::TextInputType here.

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_view.h#...
content/renderer/render_view.h:662: virtual WebKit::WebRect GetCaretBounds()
OVERRIDE;
We should use ui::Rect.

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_widget.h
File content/renderer/render_widget.h (right):

http://codereview.chromium.org/7977017/diff/1/content/renderer/render_widget....
content/renderer/render_widget.h:283: virtual WebKit::WebRect GetCaretBounds();
We should use ui:Rect and ui::TextInputType here.

[kinaba, 2011-09-27 05:11:21]

James, thank you for your comments and suggestions here, too!

I'm now updating also this CL according to your comments. After the main line
patch http://codereview.chromium.org/7978019/ has stabilized and committed, I'll
submit for review.