Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 7977016: aura_shell/examples: Fix build on Linux. (Closed)

Created:
9 years, 3 months ago by tfarina
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

aura_shell/examples: Fix build on Linux. Convert config.label from string16 to wide, as views::Label still wants a std::wstring as parameter. R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/aura_shell/examples/bubble.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 3 months ago (2011-09-21 04:00:07 UTC) #1
Ben Goodger (Google)
9 years, 3 months ago (2011-09-21 04:16:11 UTC) #2
LGTM

On Tue, Sep 20, 2011 at 9:00 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> aura_shell/examples: Fix build on Linux.
>
> Convert config.label from string16 to wide, as views::Label still wants
> a std::wstring as parameter.
>
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/7977016/<http://codereview.chromium.org/7977...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M ui/aura_shell/examples/bubble.**cc
>
>
> Index: ui/aura_shell/examples/bubble.**cc
> diff --git a/ui/aura_shell/examples/**bubble.cc b/ui/aura_shell/examples/*
> *bubble.cc
> index aedaab0aa04f664230e4a14e6447c2**cb2da4d22a..**
> 0750e8c7767cdbad82ecc204d54877**7567759b3f 100644
> --- a/ui/aura_shell/examples/**bubble.cc
> +++ b/ui/aura_shell/examples/**bubble.cc
> @@ -51,7 +51,7 @@ void CreateBubble(const BubbleConfig& config,
>   params.parent = parent;
>   bubble_widget->Init(params);
>   bubble_widget->client_view()->**AsBubbleView()->AddChildView(
> -      new views::Label(L"I am a " + config.label));
> +      new views::Label(L"I am a " + UTF16ToWideHack(config.label))**);
>  }
>
>  void CreatePointyBubble(gfx::**NativeWindow parent, const gfx::Point&
> origin) {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698