Issue 7977012: Adds a NonClientFrameView for generic toplevel windows.

Issue 7977012: Adds a NonClientFrameView for generic toplevel windows. (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)

Modified:
9 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds a NonClientFrameView for generic toplevel windows.Also adds a feeble (but better than what there was) attempt at sometimes updating the cursor. Will have to be replaced by a better system, but it's a start.http://crbug.com/97247TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102312

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+583 lines, -6 lines)			Patch
M	ui/aura/aura.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/aura/cursor.h	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
M	ui/aura/demo/demo_main.cc	View	1 2 3	1 chunk	+1 line, -4 lines	0 comments	Download
M	ui/aura/desktop.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/aura/desktop.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host_linux.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/aura/desktop_host_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/desktop_host_win.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	ui/aura/toplevel_window_event_filter.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura/toplevel_window_event_filter.cc	View		3 chunks	+21 lines, -1 line	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/aura_shell/examples/window_type_launcher.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
A	ui/aura_shell/toplevel_frame_view.h	View	1 2	1 chunk	+96 lines, -0 lines	0 comments	Download
A	ui/aura_shell/toplevel_frame_view.cc	View	1 2	1 chunk	+383 lines, -0 lines	0 comments	Download
A	ui/resources/aura/slab_close.png	View		Binary file		0 comments	Download
A	ui/resources/aura/slab_zoom.png	View		Binary file		0 comments	Download
M	ui/resources/ui_resources.grd	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 3 months ago (2011-09-22 18:06:19 UTC) #2

LGTM

http://codereview.chromium.org/7977012/diff/7012/ui/aura/cursor.h
File ui/aura/cursor.h (right):

http://codereview.chromium.org/7977012/diff/7012/ui/aura/cursor.h#newcode11
ui/aura/cursor.h:11: enum CursorType {
AURA_EXPORT

http://codereview.chromium.org/7977012/diff/7012/ui/aura_shell/toplevel_frame...
File ui/aura_shell/toplevel_frame_view.cc (right):

http://codereview.chromium.org/7977012/diff/7012/ui/aura_shell/toplevel_frame...
ui/aura_shell/toplevel_frame_view.cc:34: class WindowControlButton : public
views::CustomButton {
Add a description.

http://codereview.chromium.org/7977012/diff/7012/ui/aura_shell/toplevel_frame...
ui/aura_shell/toplevel_frame_view.cc:38: SkBitmap icon)
const SkBitmap&

http://codereview.chromium.org/7977012/diff/7012/ui/aura_shell/toplevel_frame...
File ui/aura_shell/toplevel_frame_view.h (right):

http://codereview.chromium.org/7977012/diff/7012/ui/aura_shell/toplevel_frame...
ui/aura_shell/toplevel_frame_view.h:23: class AURA_SHELL_EXPORT
ToplevelFrameView : public views::NonClientFrameView,
Add a description

Expand Messages | Collapse Messages