Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 7977004: Make heap iterable in PrepareForBreakPoints. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry, Rico
CC:
v8-dev
Visibility:
Public.

Description

Make heap iterable in PrepareForBreakPoints. When aborting incremental marking with compaction discard all slots collected on evacuation candidates. R=ricow@chromium.org BUG=v8:1700 TEST=inspector/debugger/debugger-step-in.html Committed: http://code.google.com/p/v8/source/detail?r=9360

Patch Set 1 #

Patch Set 2 : fix compilation #

Patch Set 3 : abort compaction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/debug.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/mark-compact.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-20 11:54:08 UTC) #1
Vyacheslav Egorov (Chromium)
Please review Erik.
9 years, 3 months ago (2011-09-21 10:31:19 UTC) #2
Rico
9 years, 3 months ago (2011-09-21 10:36:32 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698