Issue 7976046: Fixed string.split: always convert non-regexp separator to string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7976046: Fixed string.split: always convert non-regexp separator to string. (Closed)

Created:
9 years, 3 months ago by Yang

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fixed string.split: always convert non-regexp separator to string. BUG=v8:1711 TEST=mjsunit/regress/regress-1711.js Committed: http://code.google.com/p/v8/source/detail?r=9371

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
	M	src/string.js	View		3 chunks	+5 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-1711.js	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

Please refer to ECMA-262 15.5.4.14 Converting non-regexp separator to string must not be skipped because ...

9 years, 3 months ago (2011-09-22 08:13:24 UTC) #1

Jakob Kummerow

9 years, 3 months ago (2011-09-22 08:16:51 UTC) #2

LGTM with the indentation nit fixed that you've already noticed yourself.