Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 7976046: Fixed string.split: always convert non-regexp separator to string. (Closed)

Created:
9 years, 3 months ago by Yang
Modified:
9 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fixed string.split: always convert non-regexp separator to string. BUG=v8:1711 TEST=mjsunit/regress/regress-1711.js Committed: http://code.google.com/p/v8/source/detail?r=9371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/string.js View 3 chunks +5 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-1711.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
Please refer to ECMA-262 15.5.4.14 Converting non-regexp separator to string must not be skipped because ...
9 years, 3 months ago (2011-09-22 08:13:24 UTC) #1
Jakob Kummerow
9 years, 3 months ago (2011-09-22 08:16:51 UTC) #2
LGTM with the indentation nit fixed that you've already noticed yourself.

Powered by Google App Engine
This is Rietveld 408576698