Issue 7976042: Temporarily turning off stripping for mac builds on the main waterfall to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7976042: Temporarily turning off stripping for mac builds on the main waterfall to (Closed)

Created:
9 years, 3 months ago by bradn

Modified:
9 years, 3 months ago

Reviewers:
Brad Chen (chromium), Brad Chen

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Temporarily turning off stripping for mac builds on the main waterfall to debug intermittent crash seen only there. BUG=None TEST=None R=bradchen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102221

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	build/common.gypi	View	1	2 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brad Chen

9 years, 3 months ago (2011-09-22 01:06:14 UTC) #2

LGTM. Two nits below.

Thanks!

http://codereview.chromium.org/7976042/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7976042/diff/1/build/common.gypi#newcode1972
build/common.gypi:1972: # TODO(bradchen): switch back to the following once we
have enough results.
nit: linelength

http://codereview.chromium.org/7976042/diff/1/build/common.gypi#newcode1977
build/common.gypi:1977: ['"<!(uname -n)"=="xserve6-m1.golo.chromium.org"', {
Please double check the gyp syntax and server name as I'm not in a good position
to do so.

Expand Messages | Collapse Messages