Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 7976035: Add a backwards compatibility unittest. (Closed)

Created:
9 years, 3 months ago by dgarrett
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a backwards compatibility unittest. This is a resubmit of CL 7915007. BUG=None TEST=New Unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, --1 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M courgette/courgette.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A courgette/testdata/setup1-setup2.v1.patch View 0 chunks +-1 lines, --1 lines 0 comments Download
A courgette/versioning_unittest.cc View 1 chunk +83 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dgarrett
I believe this to be a valid CL and that the trybot problems are unreleased. ...
9 years, 3 months ago (2011-09-21 21:06:54 UTC) #1
dgarrett
9 years, 3 months ago (2011-09-22 02:20:58 UTC) #2
sra1
LGTM
9 years, 3 months ago (2011-09-22 02:47:42 UTC) #3
dgarrett
Stephen... are the courgette tests run as part of the try bot results, or only ...
9 years, 3 months ago (2011-09-22 18:14:49 UTC) #4
sra1
On Thu, Sep 22, 2011 at 11:14 AM, <dgarrett@chromium.org> wrote: > Stephen... are the courgette ...
9 years, 3 months ago (2011-09-22 18:32:10 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/dgarrett@chromium.org/7976035/1
9 years, 3 months ago (2011-09-22 23:58:00 UTC) #6
commit-bot: I haz the power
Change committed as 102428
9 years, 3 months ago (2011-09-23 02:33:45 UTC) #7
dgarrett
And the same problem is happening again. These tests must not be running on the ...
9 years, 3 months ago (2011-09-23 03:07:12 UTC) #8
dgarrett
9 years, 3 months ago (2011-09-23 03:08:05 UTC) #9
And the same problem is happening again. These tests must not be running on the
trybots.

I wonder if I can get them activated there while working on this stuff?

Powered by Google App Engine
This is Rietveld 408576698