Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: views/widget/widget.cc

Issue 7976028: Fix infinite loop in GetInputMethod. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/widget/widget.cc
diff --git a/views/widget/widget.cc b/views/widget/widget.cc
index a02d9f29fdf7e7ce59e6254eb2b3013aa8934385..85552c9f7a586c46e7c775f80de60f49dcda71a0 100644
--- a/views/widget/widget.cc
+++ b/views/widget/widget.cc
@@ -622,7 +622,12 @@ InputMethod* Widget::GetInputMethod() {
return input_method_.get();
} else {
Widget* toplevel = GetTopLevelWidget();
- return toplevel ? toplevel->GetInputMethod() : NULL;
+ // If GetTopLevelWidget() returns itself which is not toplevel,
+ // the widget is detached from toplevel widget.
+ // TODO(oshima): Fix GetTopLevelWidget() to return NULL
+ // if there is no toplevel. We probably need to add GetTopMostWidget()
+ // to replace some use cases.
+ return toplevel && toplevel != this ? toplevel->GetInputMethod() : NULL;
}
}

Powered by Google App Engine
This is Rietveld 408576698