Fix infinite loop in GetInputMethod.

Fix infinite loop in GetInputMethod.

RWHVV shouldn't update ime if there is no inputmethod associated with the view.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102225

[mmocny, 2011-09-21 18:57:53]

Other than not compiling :) it seems to have fixed the issue.

Or, at least, made those particular symptoms go away.

http://codereview.chromium.org/7976028/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/render_widget_host_view_views.cc (right):

http://codereview.chromium.org/7976028/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/render_widget_host_view_views.cc:279: InputMethod*
input_method = GetInputMethod();
won't compile, change to:

views::InputMethod* ...

[Peng, 2011-09-21 19:26:13]

On 2011/09/21 19:13:49, oshima wrote:

GetInputMethod() can returns NULL in this CL. I think we have to check the
return value everywhere. :(

[oshima, 2011-09-21 19:41:33]

On 2011/09/21 19:26:13, Peng wrote:
> On 2011/09/21 19:13:49, oshima wrote:
> 
> GetInputMethod() can returns NULL in this CL. I think we have to check the
> return value everywhere. :(

There was no guarantee that it never returned NULL. See
native_widget_gtk.cc. In NativWidgetViews, OnActivate/OnKeyEvent should never
been called on hidden/detached widget, and should be 
a bug if this happens.

[Peng, 2011-09-21 20:10:49]

On 2011/09/21 19:41:33, oshima wrote:
> On 2011/09/21 19:26:13, Peng wrote:
> > On 2011/09/21 19:13:49, oshima wrote:
> > 
> > GetInputMethod() can returns NULL in this CL. I think we have to check the
> > return value everywhere. :(
> 
> There was no guarantee that it never returned NULL. See
> native_widget_gtk.cc. In NativWidgetViews, OnActivate/OnKeyEvent should never
> been called on hidden/detached widget, and should be 
> a bug if this happens.

I understood. LGTM

[sky, 2011-09-21 21:01:45]

LGTM

http://codereview.chromium.org/7976028/diff/5001/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7976028/diff/5001/views/widget/widget.cc#newco...
views/widget/widget.cc:630: return toplevel && toplevel != this ?
toplevel->GetInputMethod() : NULL;
nit: parens around toplevel && toplevel != this

[oshima, 2011-09-22 01:17:19]

http://codereview.chromium.org/7976028/diff/5001/views/widget/widget.cc
File views/widget/widget.cc (right):

http://codereview.chromium.org/7976028/diff/5001/views/widget/widget.cc#newco...
views/widget/widget.cc:630: return toplevel && toplevel != this ?
toplevel->GetInputMethod() : NULL;
On 2011/09/21 21:01:46, sky wrote:
> nit: parens around toplevel && toplevel != this

Done.