Chromium Code Reviews Chromium Code Reviews
Issue
7976026:
Prepare for moving grit to its own open-source project. This mostly (Closed)
DescriptionPrepare for moving grit to its own open-source project.
This involved:
- Removing a grit->Chrome dependency that had been added in a unit test;
- Moving the very project-specific resource_ids file to not sit in the same directory as the grit files (albeit in a hacky way; will fix this better later as per TODOs in code); and
- Removing the hard-coding of "project base dir is two directories up from grit.py" and instead making that a parameter of resource_ids (as per TODO in code, this should later move to be a parameter of the .grd file).
Also fixed a minor bug in relpath in misc.py, and fixed line length in grd_runner.py.
The next steps will be to copy the tools/grit folder into http://code.google.com/p/grit-i18n, then in a single commit delete tools/grit from the Chrome repo and add it back in via DEPS.
Follow-up fixes will address some of the TODOs, and later fixes will generalize a few things and add some features available in a different version of grit.
BUG=97420
TEST=trybots should catch any breakage here
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102276
Patch Set 1 #Patch Set 2 : Use a super-simple approach for resource_ids as an initial step. #Patch Set 3 : Maybe ready for review. #Patch Set 4 : Add TODO. #
Total comments: 10
Patch Set 5 : Merge to lkgr. #Patch Set 6 : Respond to review comments. #
Total comments: 1
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
