Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/heap.cc

Issue 7976024: Add dynamic stack frame alignment to optimized functions with untagged doubles on the stack. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporate code review comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.h ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2226 matching lines...) Expand 10 before | Expand all | Expand 10 after
2237 set_false_value(obj); 2237 set_false_value(obj);
2238 2238
2239 { MaybeObject* maybe_obj = CreateOddball("hole", 2239 { MaybeObject* maybe_obj = CreateOddball("hole",
2240 Smi::FromInt(-1), 2240 Smi::FromInt(-1),
2241 Oddball::kTheHole); 2241 Oddball::kTheHole);
2242 if (!maybe_obj->ToObject(&obj)) return false; 2242 if (!maybe_obj->ToObject(&obj)) return false;
2243 } 2243 }
2244 set_the_hole_value(obj); 2244 set_the_hole_value(obj);
2245 2245
2246 { MaybeObject* maybe_obj = CreateOddball("arguments_marker", 2246 { MaybeObject* maybe_obj = CreateOddball("arguments_marker",
2247 Smi::FromInt(-4), 2247 Smi::FromInt(-2),
2248 Oddball::kArgumentMarker); 2248 Oddball::kArgumentMarker);
2249 if (!maybe_obj->ToObject(&obj)) return false; 2249 if (!maybe_obj->ToObject(&obj)) return false;
2250 } 2250 }
2251 set_arguments_marker(obj); 2251 set_arguments_marker(obj);
2252 2252
2253 { MaybeObject* maybe_obj = CreateOddball("no_interceptor_result_sentinel", 2253 { MaybeObject* maybe_obj = CreateOddball("no_interceptor_result_sentinel",
2254 Smi::FromInt(-2), 2254 Smi::FromInt(-3),
2255 Oddball::kOther); 2255 Oddball::kOther);
2256 if (!maybe_obj->ToObject(&obj)) return false; 2256 if (!maybe_obj->ToObject(&obj)) return false;
2257 } 2257 }
2258 set_no_interceptor_result_sentinel(obj); 2258 set_no_interceptor_result_sentinel(obj);
2259 2259
2260 { MaybeObject* maybe_obj = CreateOddball("termination_exception", 2260 { MaybeObject* maybe_obj = CreateOddball("termination_exception",
2261 Smi::FromInt(-3), 2261 Smi::FromInt(-4),
2262 Oddball::kOther); 2262 Oddball::kOther);
2263 if (!maybe_obj->ToObject(&obj)) return false; 2263 if (!maybe_obj->ToObject(&obj)) return false;
2264 } 2264 }
2265 set_termination_exception(obj); 2265 set_termination_exception(obj);
2266 2266
2267 { MaybeObject* maybe_obj = CreateOddball("frame_alignment_marker",
2268 Smi::FromInt(-5),
2269 Oddball::kOther);
2270 if (!maybe_obj->ToObject(&obj)) return false;
2271 }
2272 set_frame_alignment_marker(obj);
2273 STATIC_ASSERT(Oddball::kLeastHiddenOddballNumber == -5);
2274
2267 // Allocate the empty string. 2275 // Allocate the empty string.
2268 { MaybeObject* maybe_obj = AllocateRawAsciiString(0, TENURED); 2276 { MaybeObject* maybe_obj = AllocateRawAsciiString(0, TENURED);
2269 if (!maybe_obj->ToObject(&obj)) return false; 2277 if (!maybe_obj->ToObject(&obj)) return false;
2270 } 2278 }
2271 set_empty_string(String::cast(obj)); 2279 set_empty_string(String::cast(obj));
2272 2280
2273 for (unsigned i = 0; i < ARRAY_SIZE(constant_symbol_table); i++) { 2281 for (unsigned i = 0; i < ARRAY_SIZE(constant_symbol_table); i++) {
2274 { MaybeObject* maybe_obj = 2282 { MaybeObject* maybe_obj =
2275 LookupAsciiSymbol(constant_symbol_table[i].contents); 2283 LookupAsciiSymbol(constant_symbol_table[i].contents);
2276 if (!maybe_obj->ToObject(&obj)) return false; 2284 if (!maybe_obj->ToObject(&obj)) return false;
(...skipping 4111 matching lines...) Expand 10 before | Expand all | Expand 10 after
6388 } 6396 }
6389 isolate_->heap()->store_buffer()->Filter(MemoryChunk::ABOUT_TO_BE_FREED); 6397 isolate_->heap()->store_buffer()->Filter(MemoryChunk::ABOUT_TO_BE_FREED);
6390 for (chunk = chunks_queued_for_free_; chunk != NULL; chunk = next) { 6398 for (chunk = chunks_queued_for_free_; chunk != NULL; chunk = next) {
6391 next = chunk->next_chunk(); 6399 next = chunk->next_chunk();
6392 isolate_->memory_allocator()->Free(chunk); 6400 isolate_->memory_allocator()->Free(chunk);
6393 } 6401 }
6394 chunks_queued_for_free_ = NULL; 6402 chunks_queued_for_free_ = NULL;
6395 } 6403 }
6396 6404
6397 } } // namespace v8::internal 6405 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap.h ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698