Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 7976023: Remove the old chrome://extensions page, since the URL now redirects to the new Settings page.BUG... (Closed)

Created:
9 years, 3 months ago by Finnur
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove the old chrome://extensions page, since the URL now redirects to the new Settings page. BUG=87377 TEST=None, the page is already inaccessible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102473

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2035 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/extensions_ui.h View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/extensions/extensions_ui.cc View 1 chunk +0 lines, -806 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/extensions_ui.html View 1 chunk +0 lines, -579 lines 0 comments Download
D chrome/browser/resources/extensions_ui.js View 1 chunk +0 lines, -412 lines 0 comments Download
M chrome/browser/resources/options/extension_list.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 3 chunks +13 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
You wanna give it a proper burial by reviewing? :) Also, please keep an eye ...
9 years, 3 months ago (2011-09-21 13:29:02 UTC) #1
arv (Not doing code reviews)
LGTM Raf is on vacation.
9 years, 3 months ago (2011-09-22 19:11:42 UTC) #2
Mihai Parparita -not on Chrome
lgtm
9 years, 3 months ago (2011-09-22 19:14:53 UTC) #3
Finnur
9 years, 3 months ago (2011-09-23 09:43:44 UTC) #4
Thanks a lot to both of you for the quick response. I was kicking myself when I
woke up this morning that I forgot to send this to someone else. You've saved me
a timezone cycle on this CL. :)

Powered by Google App Engine
This is Rietveld 408576698