Issue 7976022: Omit content settings type auto select certificate when updating the extensions UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7976022: Omit content settings type auto select certificate when updating the extensions UI (Closed)

Created:
9 years, 3 months ago by markusheintz_

Modified:
9 years, 3 months ago

Reviewers:
Bernhard Bauer, commit-bot: I haz the power, battre

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Omit content settings type auto select certificate when updating the extensions UI BUG=97381 TEST=Chrome not crashing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102200

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/webui/options/content_settings_handler.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

markusheintz_

Please review this CL quickly. It's just one line. Thanks.

9 years, 3 months ago (2011-09-21 12:47:02 UTC) #1

Bernhard Bauer

LGTM http://codereview.chromium.org/7976022/diff/1/chrome/browser/ui/webui/options/content_settings_handler.cc File chrome/browser/ui/webui/options/content_settings_handler.cc (right): http://codereview.chromium.org/7976022/diff/1/chrome/browser/ui/webui/options/content_settings_handler.cc#newcode450 chrome/browser/ui/webui/options/content_settings_handler.cc:450: case CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE: Nit: if we plan on extending ...

9 years, 3 months ago (2011-09-21 12:52:34 UTC) #2

markusheintz_

I totally agree, having a separate list would be better. Thanks for the review. I'll ...

9 years, 3 months ago (2011-09-21 19:33:14 UTC) #3

Change committed as 102200

Expand Messages | Collapse Messages