Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: chrome/browser/chromeos/input_method/ibus_controller.h

Issue 7976021: Tiny clean-up of ibus_cotroller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/ibus_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_
6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_ 6 #define CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 return virtual_keyboard_layouts_; 43 return virtual_keyboard_layouts_;
44 } 44 }
45 const std::string& language_code() const { return language_code_; } 45 const std::string& language_code() const { return language_code_; }
46 46
47 // Returns the fallback input method descriptor (the very basic US 47 // Returns the fallback input method descriptor (the very basic US
48 // keyboard). This function is mostly used for testing, but may be used 48 // keyboard). This function is mostly used for testing, but may be used
49 // as the fallback, when there is no other choice. 49 // as the fallback, when there is no other choice.
50 static InputMethodDescriptor GetFallbackInputMethodDescriptor(); 50 static InputMethodDescriptor GetFallbackInputMethodDescriptor();
51 51
52 private: 52 private:
53 // For GetFallbackInputMethodDescriptor(). Use the public constructor instead.
54 InputMethodDescriptor(const std::string& in_id,
55 const std::string& in_keyboard_layout,
56 const std::string& in_virtual_keyboard_layouts,
57 const std::string& in_language_code);
58
53 // An ID that identifies an input method engine (e.g., "t:latn-post", 59 // An ID that identifies an input method engine (e.g., "t:latn-post",
54 // "pinyin", "hangul"). 60 // "pinyin", "hangul").
55 std::string id_; 61 std::string id_;
56 // A preferred physical keyboard layout for the input method (e.g., "us", 62 // A preferred physical keyboard layout for the input method (e.g., "us",
57 // "us(dvorak)", "jp"). Comma separated layout names do NOT appear. 63 // "us(dvorak)", "jp"). Comma separated layout names do NOT appear.
58 std::string keyboard_layout_; 64 std::string keyboard_layout_;
59 // Preferred virtual keyboard layouts for the input method. Comma separated 65 // Preferred virtual keyboard layouts for the input method. Comma separated
60 // layout names in order of priority, such as "handwriting,us", could appear. 66 // layout names in order of priority, such as "handwriting,us", could appear.
61 std::vector<std::string> virtual_keyboard_layouts_; 67 std::vector<std::string> virtual_keyboard_layouts_;
62 // Language codes like "ko", "ja", "zh_CN", and "t". 68 // Language codes like "ko", "ja", "zh_CN", and "t".
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 virtual bool InputMethodIdIsWhitelisted( 265 virtual bool InputMethodIdIsWhitelisted(
260 const std::string& input_method_id) = 0; 266 const std::string& input_method_id) = 0;
261 // Returns true if |xkb_layout| is supported. 267 // Returns true if |xkb_layout| is supported.
262 virtual bool XkbLayoutIsSupported(const std::string& xkb_layout) = 0; 268 virtual bool XkbLayoutIsSupported(const std::string& xkb_layout) = 0;
263 }; 269 };
264 270
265 } // namespace input_method 271 } // namespace input_method
266 } // namespace chromeos 272 } // namespace chromeos
267 273
268 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_ 274 #endif // CHROME_BROWSER_CHROMEOS_INPUT_METHOD_IBUS_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/ibus_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698