Wires up mouse capture code for aura.

Wires up mouse capture code for aura.

BUG=none
TEST=none
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102115

[sky, 2011-09-21 03:20:14]

Let me know what you think of the approach I took for finding the root. I could
also provide virtual methods that RootWindow overrides.

  -Scott

[Ben Goodger (Google), 2011-09-21 04:15:21]

http://codereview.chromium.org/7976020/diff/2001/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

http://codereview.chromium.org/7976020/diff/2001/ui/aura/root_window.cc#newco...
ui/aura/root_window.cc:80: // When a window is being destroyed it's likely that
the windows delegate
window's
WindowDelegate
delegate

http://codereview.chromium.org/7976020/diff/2001/ui/aura/window.cc
File ui/aura/window.cc (right):

http://codereview.chromium.org/7976020/diff/2001/ui/aura/window.cc#newcode46
ui/aura/window.cc:46: RootWindow* root = GetRoot();
Can you maybe move the FocusManager code above into the root's destroying
function too?

http://codereview.chromium.org/7976020/diff/2001/ui/aura/window.cc#newcode250
ui/aura/window.cc:250: RootWindow* Window::GetRoot() {
rather than adding this state, how about a virtual function that crawls up, like
GetFocusManager, that RootWindow overrides.

[sky, 2011-09-21 14:26:40]

Updated.

  -Scott

On Tue, Sep 20, 2011 at 9:15 PM, <ben@chromium.org> wrote:

>
> http://codereview.chromium.**org/7976020/diff/2001/ui/aura/**
>
root_window.cc<http://codereview.chromium.org/7976020/diff/2001/ui/aura/root_window.cc>
> File ui/aura/root_window.cc (right):
>
> http://codereview.chromium.**org/7976020/diff/2001/ui/aura/**
>
root_window.cc#newcode80<http://codereview.chromium.org/7976020/diff/2001/ui/aura/root_window.cc#newcode80>
> ui/aura/root_window.cc:80: // When a window is being destroyed it's
> likely that the windows delegate
> window's
> WindowDelegate
> delegate
>
>
http://codereview.chromium.**org/7976020/diff/2001/ui/aura/**window.cc<http:/...
> File ui/aura/window.cc (right):
>
> http://codereview.chromium.**org/7976020/diff/2001/ui/aura/**
>
window.cc#newcode46<http://codereview.chromium.org/7976020/diff/2001/ui/aura/window.cc#newcode46>
> ui/aura/window.cc:46: RootWindow* root = GetRoot();
> Can you maybe move the FocusManager code above into the root's
> destroying function too?
>
> http://codereview.chromium.**org/7976020/diff/2001/ui/aura/**
>
window.cc#newcode250<http://codereview.chromium.org/7976020/diff/2001/ui/aura/window.cc#newcode250>
> ui/aura/window.cc:250: RootWindow* Window::GetRoot() {
> rather than adding this state, how about a virtual function that crawls
> up, like GetFocusManager, that RootWindow overrides.
>
>
>
http://codereview.chromium.**org/7976020/<http://codereview.chromium.org/7976...
>

[Ben Goodger (Google), 2011-09-21 14:59:16]

lgtm