Issue 7976018: [Sync Setup UI] Fix display of "Last Synced as..." in Personal Stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7976018: [Sync Setup UI] Fix display of "Last Synced as..." in Personal Stuff. (Closed)

Created:
9 years, 3 months ago by binji

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, lipalani1

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync Setup UI] Fix display of "Last Synced as..." in Personal Stuff. BUG=84907 TEST=go to chrome://settings/personal. Sign in to sync. Display should say "Last synced as..." when sync has completed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102413

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge + nit #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	chrome/browser/sync/sync_ui_util.cc	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lipalani1

sorry for the delay. After fixing the comment LGTM. http://codereview.chromium.org/7976018/diff/1/chrome/browser/sync/sync_ui_util.cc File chrome/browser/sync/sync_ui_util.cc (right): http://codereview.chromium.org/7976018/diff/1/chrome/browser/sync/sync_ui_util.cc#newcode178 chrome/browser/sync/sync_ui_util.cc:178: ...

9 years, 3 months ago (2011-09-22 20:20:21 UTC) #3

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/7976018/6001

9 years, 3 months ago (2011-09-22 23:07:23 UTC) #4

Change committed as 102413

Expand Messages | Collapse Messages