Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: chrome/browser/ui/webui/print_preview_data_source.cc

Issue 7976017: Simplified print preview printer selection to be more consistent with Chrome (Closed)
Patch Set: Fix whitespace Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_data_source.cc
diff --git a/chrome/browser/ui/webui/print_preview_data_source.cc b/chrome/browser/ui/webui/print_preview_data_source.cc
index 6383e86d0c1d20fc07031015dc32acde3581001c..16b6740b7a04dce7fb2164669643c94d8d18b6b8 100644
--- a/chrome/browser/ui/webui/print_preview_data_source.cc
+++ b/chrome/browser/ui/webui/print_preview_data_source.cc
@@ -93,25 +93,26 @@ PrintPreviewDataSource::PrintPreviewDataSource()
AddLocalizedString("printPreviewPageLabelPlural",
IDS_PRINT_PREVIEW_PAGE_LABEL_PLURAL);
const string16 shortcut_text(UTF8ToUTF16(kAdvancedPrintShortcut));
+#if defined(OS_CHROMEOS)
+ AddString("cloudPrintDialogOption", l10n_util::GetStringFUTF16(
+ IDS_PRINT_PREVIEW_CLOUD_DIALOG_OPTION,
+ shortcut_text));
+ AddLocalizedString("printWithCloudPrint",
+ IDS_PRINT_PREVIEW_MORE_PRINTERS);
+#else
AddString("systemDialogOption", l10n_util::GetStringFUTF16(
IDS_PRINT_PREVIEW_SYSTEM_DIALOG_OPTION,
shortcut_text));
-
+ AddLocalizedString("printWithCloudPrint",
+ IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT);
+#endif
AddLocalizedString("pageRangeInstruction",
IDS_PRINT_PREVIEW_PAGE_RANGE_INSTRUCTION);
AddLocalizedString("copiesInstruction", IDS_PRINT_PREVIEW_COPIES_INSTRUCTION);
AddLocalizedString("signIn", IDS_PRINT_PREVIEW_SIGN_IN);
- AddLocalizedString("cloudPrinters", IDS_PRINT_PREVIEW_CLOUD_PRINTERS);
- AddLocalizedString("localPrinters", IDS_PRINT_PREVIEW_LOCAL_PRINTERS);
- AddLocalizedString("manageCloudPrinters",
- IDS_PRINT_PREVIEW_MANAGE_CLOUD_PRINTERS);
- AddLocalizedString("manageLocalPrinters",
- IDS_PRINT_PREVIEW_MANAGE_LOCAL_PRINTERS);
AddLocalizedString("managePrinters", IDS_PRINT_PREVIEW_MANAGE_PRINTERS);
AddLocalizedString("printWithCloudPrintWait",
IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT_WAIT);
- AddLocalizedString("printWithCloudPrint",
- IDS_PRINT_PREVIEW_PRINT_WITH_CLOUD_PRINT);
AddLocalizedString("incrementTitle", IDS_PRINT_PREVIEW_INCREMENT_TITLE);
AddLocalizedString("decrementTitle", IDS_PRINT_PREVIEW_DECREMENT_TITLE);
AddLocalizedString("printPagesLabel", IDS_PRINT_PREVIEW_PRINT_PAGES_LABEL);
« no previous file with comments | « chrome/browser/resources/print_preview/print_preview_cloud.js ('k') | chrome/browser/ui/webui/print_preview_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698